The number of records deleted are doubled every run #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobyns
approved these changes
Mar 17, 2025
JesperSchulz
approved these changes
Mar 17, 2025
AndreasMoth
deleted the
private/anmoth/TotalNumberOfRecordsDeletedOverflow
branch
AndreasMoth
added a commit
that referenced
this pull request
Mar 17, 2025
Every time SafeApplyRetentionPolicy is called, the number of records deleted more than doubles. This is because we first set number of deleted records to the number already deleted ex. 1000, then cleanup records (it will increase this value further say it deletes 100, now 1100), then TotalNumberOfRecordsDeleted is incremented to 2100 instead of just 1100. Fixes [AB#571294](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/571294)
AndreasMoth
added a commit
that referenced
this pull request
Mar 17, 2025
Every time SafeApplyRetentionPolicy is called, the number of records deleted more than doubles. This is because we first set number of deleted records to the number already deleted ex. 1000, then cleanup records (it will increase this value further say it deletes 100, now 1100), then TotalNumberOfRecordsDeleted is incremented to 2100 instead of just 1100. Fixes [AB#571294](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/571294)
AndreasMoth
added a commit
that referenced
this pull request
Mar 17, 2025
Every time SafeApplyRetentionPolicy is called, the number of records deleted more than doubles. This is because we first set number of deleted records to the number already deleted ex. 1000, then cleanup records (it will increase this value further say it deletes 100, now 1100), then TotalNumberOfRecordsDeleted is incremented to 2100 instead of just 1100. Fixes [AB#571294](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/571294)
AndreasMoth
added a commit
that referenced
this pull request
Mar 17, 2025
Every time SafeApplyRetentionPolicy is called, the number of records deleted more than doubles. This is because we first set number of deleted records to the number already deleted ex. 1000, then cleanup records (it will increase this value further say it deletes 100, now 1100), then TotalNumberOfRecordsDeleted is incremented to 2100 instead of just 1100. Fixes [AB#571294](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/571294)
AndreasMoth
added a commit
that referenced
this pull request
Mar 17, 2025
Every time SafeApplyRetentionPolicy is called, the number of records deleted more than doubles. This is because we first set number of deleted records to the number already deleted ex. 1000, then cleanup records (it will increase this value further say it deletes 100, now 1100), then TotalNumberOfRecordsDeleted is incremented to 2100 instead of just 1100. Fixes [AB#571294](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/571294)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time SafeApplyRetentionPolicy is called, the number of records deleted more than doubles. This is because we first set number of deleted records to the number already deleted ex. 1000, then cleanup records (it will increase this value further say it deletes 100, now 1100), then TotalNumberOfRecordsDeleted is incremented to 2100 instead of just 1100.
Fixes AB#571294