Skip to content

Conversation

@ceciliaavila
Copy link
Collaborator

#minor

Description

This pull request enhances the JavaScript sample bots by incorporating the @ts-check flag and resolving existing TypeScript issues.

Proposed Changes

  • Added the ts-check flag in all .js files and fixed the TS issues, which include:
    • Adding default values to variables to avoid undefined results.
    • Importing types used in documentation with the @import comment tag.
  • Replaced inexistent URLs in 08.suggested-actions/bots/suggestedActionsBot.js.
  • Added the @ts-ignore tag to bypass issues that would require major typing fixes.
  • Added missing properties in output result in 44.prompt-for-user-input/bots/customPromptBot.js
  • Added missing dotenv declaration in 83.named-pipe-sample/named-pipe-bot/utils/renewDirectLineToken.js.

Testing

All samples were tested with the latest version of botbuilder (4.23.2). These images show some of the samples working:
image
image
image
image
image

@tracyboehrer tracyboehrer merged commit 30f96cb into main Apr 1, 2025
33 checks passed
@tracyboehrer tracyboehrer deleted the southworks/add/ts-check-flag branch April 1, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants