-
Notifications
You must be signed in to change notification settings - Fork 223
Local sealing #6966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Local sealing #6966
Changes from 107 commits
Commits
Show all changes
138 commits
Select commit
Hold shift + click to select a range
a608b81
Check the integrity of decrypted ciphertext
cjen1-msft fd8ffbf
Refactor
cjen1-msft 5d741cf
Fmt
cjen1-msft 79f7a0a
Add config options to startup_config for sealing
cjen1-msft 6f29ebf
Checkpoint for unsealing ledger
cjen1-msft a2010bc
Disable local sealing by default
cjen1-msft a2f014b
revert accidental removal of previous_identity_file field
cjen1-msft 665f04f
Add test and ensure it passes
cjen1-msft edc8423
Reformat
cjen1-msft 28c1eb7
Run recovery test on 3 nodes
cjen1-msft f3fedeb
Horrible hacks to allow unsealing.
cjen1-msft ef57b9d
Fix sealing on joined nodes
cjen1-msft 4ded7a0
Add test for rekey and refresh of recovery shares
cjen1-msft d79f52e
Ensure sealing key is set by platform not device
cjen1-msft 9780bb6
Expand testing to include all rekeying paths
cjen1-msft 56b361e
Add config changes to cchost_config.json
cjen1-msft 79f995f
Throw error on unsealing fail. Disallow virtual unsealing
cjen1-msft 5507b5f
Merge branch 'main' into local-sealing
cjen1-msft 4684613
Ensure that auto-dr is gated on an attested field (CLI args)
cjen1-msft cef27e4
Reformat
cjen1-msft aed43a0
Run schema_test_cft in 1ES pools
cjen1-msft 2f841f7
Fix typo
cjen1-msft 0af717b
Ensure the TCB hasn't changed between sealing and unsealing
cjen1-msft 4a2a5ca
Fmt
cjen1-msft 87d62fb
Refactor where sealing is done to be more principled.
cjen1-msft 59e406e
PR comments
cjen1-msft f614775
Roll back running e2e tests on snp c-aci
cjen1-msft f212366
Add test for unsealing using corrupt ledgers
cjen1-msft c94d852
Ensure corruption test runs
cjen1-msft 8a808f0
Format and propogate change of sealed_ledger_secret to jinja
cjen1-msft 5f0703c
Store tag
cjen1-msft 5a7d455
Fixup test
cjen1-msft de1a6ee
MUST_REVERT: Only run the local-sealing test
cjen1-msft e8cf0d1
Add golden file for a sealed ledger secret from another node
cjen1-msft be650dd
Make sealed_ledger_secret_location driven by enable_auto_dr
cjen1-msft c351e6b
Fmt
cjen1-msft c0fde7a
Pass enable_auto_dr through to node
cjen1-msft d9ba872
Add logging for sealing of secrets.
cjen1-msft c89bca0
reformat
cjen1-msft d3fa6d2
corrupted sealing should not have spaces
cjen1-msft c404aad
Ensure the TCB hasn't changed between sealing and unsealing
cjen1-msft 99f7c94
Add test that tcb changes are reflected in different keys.
cjen1-msft 907acb3
Trial remove bitfields
cjen1-msft 01b49fd
Remove bitfields from guest_field_select and account for endianness
cjen1-msft 6010635
Use bitwise operators rather than bitfields
cjen1-msft 377b328
Merge branch 'bitfields-eol' into local-sealing
cjen1-msft f33ff23
Fmt
cjen1-msft 746e25a
Default initialise TcbVersions
cjen1-msft f3a1b4e
Merge branch 'bitfields-eol' into local-sealing
cjen1-msft 82b74d8
Change sealed key
cjen1-msft 50f2079
Log tcb version when sealing
cjen1-msft 8f4888d
Expand test to show that decrypting with a incorrect key causes a fai…
cjen1-msft 0cb9acb
Add unit test for junk keys
cjen1-msft c86e9ad
fix
cjen1-msft 6c0efde
fix
cjen1-msft c25da8e
Fix bug
cjen1-msft a5d094e
Fmt and tidy
cjen1-msft 8f18d1a
ReFmt
cjen1-msft 6970dc2
Randomise IVs for sealing
cjen1-msft dd9025e
Tidy
cjen1-msft f128a8c
Update sealing file
cjen1-msft aa2428e
Maybe fix asan
cjen1-msft 7513fe1
Tag e2e_ops runs
cjen1-msft 44ef058
Reformat
cjen1-msft d1b0b27
Merge branch 'main' into local-sealing
cjen1-msft 1f265c1
Revert schema test on 1ES pools
cjen1-msft 076cf3c
Ensure e2e_tutorial is accessible
cjen1-msft 289865d
Reorder
cjen1-msft 12f3c61
Add .aad file
cjen1-msft 7d1d20b
Move local sealing to its own file
cjen1-msft 6e7c468
Maybe fix sealing
cjen1-msft 90efd59
Actually write the thing
cjen1-msft 922d072
Merge branch 'main' into local-sealing
cjen1-msft 470f717
Ensure that the correct file is unsealed
cjen1-msft 299fc74
Add schema_test_cft
cjen1-msft 7dbc52e
Use canned aad
cjen1-msft abb4595
Add encoding
cjen1-msft de93733
fix
cjen1-msft c54c7fb
add pragma
cjen1-msft 839f397
Bump timeout to 20 mins and run schema_test_cft
cjen1-msft 3cdbe7c
Change local sealing to act on a directory
cjen1-msft 1f47db8
Pass through versions to unsealing
cjen1-msft 4ea7d00
Try to create sealing directory
cjen1-msft 157a5b7
Fmt
cjen1-msft d6c216b
move most tests to dir version
cjen1-msft fec978d
Tentative fix for tests for sealing directory
cjen1-msft 0a7746a
Validate that the platform is snp before allowing local unsealing
cjen1-msft ef0576e
Fix copy semantics
cjen1-msft 624e6c5
Fix substring of ledger files
cjen1-msft 52c20d7
fmt
cjen1-msft e2f69ec
Fix test (bar corruption)
cjen1-msft 612c16b
Merge branch 'main' into local-sealing
cjen1-msft bc942ac
Reboop
cjen1-msft 2b1d729
fix condition for ignoring sealed secrets
cjen1-msft bf39385
Better corruption test
cjen1-msft 2433d50
fix return type of max_version corruption
cjen1-msft e0945be
Ensure corrupted secrets dir exists
cjen1-msft e846051
add src_dir
cjen1-msft cb51072
Add mkdir
cjen1-msft 60a3e18
Better error messages?
cjen1-msft f7915e6
Allow corrutpions to be ignored
cjen1-msft e0ef18f
Better failure error message
cjen1-msft aadd686
Fix version check
cjen1-msft 05ce786
Add test showing that invalid files are ignored.
cjen1-msft dff4b17
Reboop
cjen1-msft 0092ec6
Specify error in snp_ioctl_test
cjen1-msft b52cada
Merge branch 'main' into local-sealing
cjen1-msft 22870f2
Update src/node/local_sealing.h
cjen1-msft e6bf097
single json file
cjen1-msft 13c39a6
Update e2e_ops
cjen1-msft c62c556
Update comment
cjen1-msft d8fe670
Fix typo
cjen1-msft abaef07
Remove cli flag and add documentation for new kv writes
cjen1-msft 3ba484c
Fix
cjen1-msft ef539a9
fix
cjen1-msft e3326dc
Reformat and bump openapi
cjen1-msft 1b2e5ab
bump version change
cjen1-msft 32af383
Fix bug ...
cjen1-msft 4edc2d6
Fix
cjen1-msft 07876cf
Fix bytes
cjen1-msft 5ce8e5e
fix
cjen1-msft 8667e3b
Fix encoding of aad
cjen1-msft 4ef5d03
Fix the b64 call
cjen1-msft 97e3d76
Merge branch 'main' into local-sealing
achamayou bd883a2
fix ops encoding
cjen1-msft 4f10bca
comment
cjen1-msft 1666966
Reboop
cjen1-msft 873af6d
remove copy_tree
cjen1-msft d6ebb19
Merge branch 'main' into local-sealing
achamayou 55b8e3f
Update tests/infra/path.py
achamayou 3a4d730
Update tests/schema.py
achamayou 7b46682
Update .github/workflows/ci.yml
achamayou b2b37e5
Add testing of kv info and documentation.
cjen1-msft f10626d
Update doc/host_config_schema/cchost_config.json
cjen1-msft 5fa8f66
Update doc/host_config_schema/cchost_config.json
cjen1-msft a5350f5
Update doc/operations/recovery.rst
cjen1-msft 7a5339e
Update src/node/node_state.h
cjen1-msft ef7de58
Merge branch 'main' into local-sealing
achamayou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.