Accept consistently dash-separated args in ccf_cose_sign1
#7008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever using
ccf_cose_sign1
by hand, we previously had to parse errors like:To eventually realise that
--ccf-gov-msg-created-at
!=--ccf-gov-msg-created_at
, because the tool expects the final separator to be an underscore, not a dash. All because the eventual protected header isccf.gov.msg.created_at
. I think this is unhelpful, and there's no reason to expose this detail at the CLI level.This change accepts both formats for this arg, so we lose no backwards compatibility but going forwards the tool is more likely to work first-time.