Skip to content

Run the "from_files" recovery tests in separate runners #7014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2025
Merged

Run the "from_files" recovery tests in separate runners #7014

merged 2 commits into from
May 16, 2025

Conversation

eddyashton
Copy link
Member

@eddyashton eddyashton commented May 15, 2025 •
edited by maxtropets
Loading

Might be a little faster, but mostly for easier debugging. Previously these started multiple networks in sequence, with the same args, meaning that they reused (and mostly overwrote) the same workspace/ directories. This is an easy way to give them unique labels and so unique directories

@eddyashton eddyashton requested a review from a team as a code owner May 15, 2025 11:36
@eddyashton eddyashton changed the title Run the "from_files" recovery tests in seaprate runners Run the "from_files" recovery tests in separate runners May 15, 2025
@eddyashton eddyashton added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 15, 2025
@achamayou achamayou added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 15, 2025
@eddyashton eddyashton added this pull request to the merge queue May 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 16, 2025
@achamayou achamayou added this pull request to the merge queue May 16, 2025
github-merge-queue bot pushed a commit that referenced this pull request May 16, 2025
@eddyashton
Run the "from_files" recovery tests in separate runners (#7014)
e060277
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 16, 2025
@achamayou achamayou enabled auto-merge May 16, 2025 16:27
@achamayou achamayou added this pull request to the merge queue May 16, 2025
Merged via the queue into microsoft:main with commit 3b7eeb7 May 16, 2025
15 checks passed
@achamayou achamayou deleted the separate_runners_for_from_files_recoveries branch May 16, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achamayou achamayou achamayou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyashton @achamayou