Remove host subprocess API #7413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the experimental and unused host subprocess API from the codebase, cleaning up dead code paths that allowed JavaScript endpoints to trigger external host processes.
Key changes:
- Removed the
ccf.host.triggerSubprocess()JavaScript API and all supporting infrastructure - Deleted test files and test execution for the host process launch functionality
- Updated CHANGELOG to document this breaking change as part of version 7.0.0-dev5
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/js-launch-host-process/src/host_process.js | Removed JavaScript functions that invoked subprocess launching |
| tests/js-launch-host-process/host_process.sh | Deleted test shell script for subprocess execution |
| tests/js-launch-host-process/host_process.py | Removed Python test suite for host process launching |
| tests/js-launch-host-process/app.json | Deleted endpoint configuration for subprocess API |
| tests/js-interpreter-reuse/src/global_handle.ts | Removed test code referencing ccf.host API |
| src/node/rpc/test/node_stub.h | Removed StubHostProcesses test stub class |
| src/node/rpc/node_interface.h | Removed trigger_host_process_launch method declaration |
| src/node/rpc/host_processes.h | Deleted HostProcesses implementation class |
| src/node/node_state.h | Removed trigger_host_process_launch implementation |
| src/js/registry.cpp | Removed HostExtension registration |
| src/js/extensions/ccf/host.cpp | Deleted JavaScript extension implementation |
| src/host/run.cpp | Removed ProcessLauncher initialization and cleanup |
| src/host/process_launcher.h | Deleted ProcessLauncher implementation |
| src/enclave/interface.h | Removed AppMessage ringbuffer messages for host processes |
| src/enclave/enclave.h | Removed HostProcesses subsystem initialization |
| include/ccf/node/host_processes_interface.h | Deleted AbstractHostProcesses interface |
| include/ccf/js/extensions/ccf/host.h | Deleted HostExtension header |
| include/ccf/js/core/context.h | Removed forward declaration |
| CMakeLists.txt | Removed host.cpp from build and deleted test registration |
| CHANGELOG.md | Documented removal in 7.0.0-dev5 release notes |
| .github/workflows/long-test.yml | Removed launch_host_process from test exclusion filter |
achamayou
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the mess of #6878 - just strip out this unused experimental subsystem.