Delete ringbuffer LoadMonitor #7528
Merged
+0
−169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the LoadMonitor functionality that tracked and logged ringbuffer message statistics. The implementation collected message counts and byte sizes from both the host and enclave, periodically logging them for debugging purposes. This monitoring added overhead without providing observed benefits, making it a candidate for removal.
Key Changes:
- Deleted the entire
LoadMonitorimplementation (100+ lines) - Removed message counting infrastructure from the
Dispatcherclass - Eliminated the
work_statsadmin message that communicated statistics between enclave and host
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/host/run.cpp | Removed LoadMonitor instantiation and header include |
| src/host/load_monitor.h | Deleted entire file containing LoadMonitor implementation |
| src/enclave/interface.h | Removed work_stats message type and payload declarations |
| src/enclave/enclave.h | Removed code that retrieved and sent message counts to host on tick |
| src/ds/messaging.h | Removed message counting infrastructure (field, retrieval and conversion methods) |
| src/ds/test/messaging.cpp | Removed test assertions that validated message count tracking |
achamayou
approved these changes
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more thorough/aggressive version of #7527.
Hopefully both show the same perf impact (or lack thereof), but I think this one should be merged regardless. Even if it's not a measurable perf impact, it's a daft amount of work, for no observed benefit.