Skip to content

Resolve simultaneous node-to-node connects deterministically #8233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Amaury Chamayou (achamayou) wants to merge 2 commits into
base: main
Choose a base branch
from
+723 −44
Open

Resolve simultaneous node-to-node connects deterministically #8233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16f728a
Resolve simultaneous node-to-node connects deterministically
achamayou Aug 28, 2026
3db1410
Add changelog entry for simultaneous connect fix
achamayou Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

### Fixed

- Nodes which open node-to-node connections to each other at the same moment now agree on which of the two connections to keep, instead of each discarding the one the other is using. Previously both could be left holding a connection whose far end no longer existed, and if the resulting disconnection was not observed - for example because a network partition dropped it - the two nodes would silently stop exchanging consensus messages, stalling elections until one of them restarted (#8233).
- Nodes from the previous service are now removed during disaster recovery instead of being retained as retired entries in `GET /node/network/nodes`, and `ledger_code.py` reports their code identities as removed (#8177).
- Fixed an edge case where a follower could incorrectly commit to an abandoned fork while synchronising with the leader, causing it to become unavailable (#8172).

Expand Down
6 changes: 6 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,6 +712,12 @@ if(BUILD_TESTS)
)
target_link_libraries(rpc_connections_test PRIVATE uv)

add_unit_test(
node_connections_test
${CMAKE_CURRENT_SOURCE_DIR}/src/host/test/node_connections.cpp
)
target_link_libraries(node_connections_test PRIVATE uv)

add_unit_test(
raft_test
${CMAKE_CURRENT_SOURCE_DIR}/src/consensus/aft/test/main.cpp
Expand Down
Loading