Switch CCF builds to C++23 - #8234
Draft
Amaury Chamayou (achamayou) wants to merge 5 commits into
Draft
Conversation
Require and propagate C++23 across CCF and downstream application targets, update the install-test compiler fallback, and adopt the newly available standard utilities. Fix C++23 build incompatibilities in SmallVector consumers and incomplete pimpl declarations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Record the downstream C++23 requirement and retained Clang 18.1.2 minimum in the 7.0.13 changelog. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Apache Arrow 15 still uses std::aligned_storage, which libstdc++ 13 deprecates in C++23 mode. Suppress that warning only while parsing Arrow and Parquet headers so project warnings remain errors. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cxx_std_23through exported CMake targetsSmallVectorinclude sites and incomplete pimpl declarationsstd::to_underlying, string and rangescontains, andstd::unreachable, and remove the obsolete comparison shimValidation
./tests.sh -L unit -E "snp_attestation_test|tls_test"(53/53 passed; the excluded tests require OpenSSL 3.3+, while the local environment provides 3.0.13)-std=gnu++23scripts/ci-checks.sh -f