Include .NET Framework build binaries in SDK - #672
Merged
Merged
Conversation
zijchen
marked this pull request as ready for review
July 22, 2025 23:03
zijchen
requested review from
chlafreniere,
dzsquared,
kburtram,
llali and
ssreerama
as code owners
July 22, 2025 23:03
There was a problem hiding this comment.
Pull Request Overview
This PR enables .NET Framework builds within the SDK by packaging framework binaries directly, eliminating the requirement for SSDT installation while maintaining optional SSDT compatibility through the BuildFromSSDT property.
- Adds .NET Framework binary packaging to include DacFx and related dependencies in the SDK
- Introduces
BuildFromSSDTconfiguration option to switch between SDK binaries and SSDT installation - Updates CI pipeline to test both SDK and SSDT build scenarios on Windows
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/Microsoft.Build.Sql.Tests/TestUtils.cs | Adds BuildFromSSDT environment variable detection for test configuration |
| test/Microsoft.Build.Sql.Tests/DotnetTestBase.cs | Conditionally applies BuildFromSSDT MSBuild property based on environment variable |
| src/Microsoft.Build.Sql/sdk/Sdk.targets | Updates import logic to choose between SDK binaries and SSDT based on BuildFromSSDT property |
| src/Microsoft.Build.Sql/sdk/Sdk.props | Defines BuildFromSSDT property and configures path selection for framework targets |
| src/Microsoft.Build.Sql/Microsoft.Build.Sql.csproj | Adds build target to copy .NET Framework binaries and updates NuGet.Versioning reference |
| .github/workflows/pr-validation.yml | Splits CI into separate jobs for dotnet and MSBuild testing with matrix strategy for SDK/SSDT builds |
llali
approved these changes
Jul 30, 2025
ssreerama
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Package .NET Framework binaries into the SDK, enabling full framework
msbuildwithout SSDT installation.Optionally
BuildFromSSDTcan be set totrueto use SSDT assets directly.In addition, go through the checklist below and check each item as you validate it is either handled or not applicable to this change.
Code Changes