Skip to content

Include .NET Framework build binaries in SDK - #672

Merged
zijchen merged 2 commits into
mainfrom
zijchen/netfx
Jul 30, 2025
Merged

Include .NET Framework build binaries in SDK#672
zijchen merged 2 commits into
mainfrom
zijchen/netfx

Conversation

@zijchen

@zijchen zijchen commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

Description

Package .NET Framework binaries into the SDK, enabling full framework msbuild without SSDT installation.

Optionally BuildFromSSDT can be set to true to use SSDT assets directly.

In addition, go through the checklist below and check each item as you validate it is either handled or not applicable to this change.

Code Changes

  • Unit tests are added, if possible
  • Existing tests are passing
  • New or updated code follows the guidelines here
  • Ensure .dacpac from changes to Microsoft.Build.Sql build process MUST be backwards compatible with older versions of SqlPackage
  • Use proper logging for MSBuild tasks

@zijchen
zijchen marked this pull request as ready for review July 22, 2025 23:03
@zijchen
zijchen requested a review from Copilot July 22, 2025 23:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables .NET Framework builds within the SDK by packaging framework binaries directly, eliminating the requirement for SSDT installation while maintaining optional SSDT compatibility through the BuildFromSSDT property.

  • Adds .NET Framework binary packaging to include DacFx and related dependencies in the SDK
  • Introduces BuildFromSSDT configuration option to switch between SDK binaries and SSDT installation
  • Updates CI pipeline to test both SDK and SSDT build scenarios on Windows

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/Microsoft.Build.Sql.Tests/TestUtils.cs Adds BuildFromSSDT environment variable detection for test configuration
test/Microsoft.Build.Sql.Tests/DotnetTestBase.cs Conditionally applies BuildFromSSDT MSBuild property based on environment variable
src/Microsoft.Build.Sql/sdk/Sdk.targets Updates import logic to choose between SDK binaries and SSDT based on BuildFromSSDT property
src/Microsoft.Build.Sql/sdk/Sdk.props Defines BuildFromSSDT property and configures path selection for framework targets
src/Microsoft.Build.Sql/Microsoft.Build.Sql.csproj Adds build target to copy .NET Framework binaries and updates NuGet.Versioning reference
.github/workflows/pr-validation.yml Splits CI into separate jobs for dotnet and MSBuild testing with matrix strategy for SDK/SSDT builds

Comment thread src/Microsoft.Build.Sql/Microsoft.Build.Sql.csproj
Comment thread src/Microsoft.Build.Sql/sdk/Sdk.targets
@zijchen
zijchen merged commit ed56bdb into main Jul 30, 2025
12 checks passed
@zijchen
zijchen deleted the zijchen/netfx branch July 30, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants