feat: WAF changes for DKM #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: Changed Bicep file to add CreatedBy tag
NirajC-Microsoft
requested review from
Avijit-Microsoft,
Dongbumlee,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Roopan-Microsoft
approved these changes
Sep 4, 2025
fix: File upload fails for supported file types (JPG, PNG, TIFF, docs)
fix: Added createdBy tag in resourcedeployment.ps1 file
feat: Down merge
feat: Implemented WAF for Infrastructure
feat: Deployment pipeline changes for WAF version
Prajwal-Microsoft
changed the title
Roopan-Microsoft
approved these changes
Sep 16, 2025
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request adds resource tagging functionality to the deployment process. The main enhancement is the creation of a resource for tagging the resource group with metadata about the template and the deployer.
Resource tagging improvements:
resourceGroupTagsresource to set tags on the resource group, includingTemplateNameandCreatedBy, which is derived from the deployer's user principal name. (Deployment/main.bicep)deployerInfovariable to access deployer details for use in resource tags. (Deployment/main.bicep)Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information