Skip to content

Fix TypeError of customized kfold method which needs 'y' #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2025
Merged

Fix TypeError of customized kfold method which needs 'y' #1450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c481086
Fix TypeError of customized kfold method which needs 'y'
thinkall Jul 31, 2025
2f8ef7a
Update windows runner to the latest version
thinkall Jul 31, 2025
d69f4bd
Ignore autogen tests
thinkall Jul 31, 2025
5db4158
Add try except for kf.split
thinkall Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-2019]
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: ["3.9", "3.10", "3.11"]
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -91,12 +91,12 @@ jobs:
- name: Test with pytest
if: matrix.python-version != '3.10'
run: |
pytest test/
pytest test/ --ignore=test/autogen
- name: Coverage
if: matrix.python-version == '3.10'
run: |
pip install coverage
coverage run -a -m pytest test
coverage run -a -m pytest test --ignore=test/autogen
coverage xml
- name: Upload coverage to Codecov
if: matrix.python-version == '3.10'
Expand Down
5 changes: 4 additions & 1 deletion flaml/automl/task/generic_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,10 @@ def evaluate_model_CV(
elif isinstance(kf, TimeSeriesSplit):
kf = kf.split(X_train_split, y_train_split)
else:
kf = kf.split(X_train_split)
try:
kf = kf.split(X_train_split)
except TypeError:
kf = kf.split(X_train_split, y_train_split)

for train_index, val_index in kf:
if shuffle:
Expand Down
Loading