-
Notifications
You must be signed in to change notification settings - Fork 546
Unpin Pydantic #1452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Unpin Pydantic #1452
Conversation
@microsoft-github-policy-service agree company="Individual" |
@thinkall I'm not sure who to ping about this. Could you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the PR. LGTM.
@thinkall It seems like older versions of ray[tune] are not compatible with pydantic v2. I bumped it to |
Hi @OlivierBinette-UpStart , ray 2 is not tested yet. Let's see will it work. |
In fact, pydantic is not pinned in FLAML. If you don't install ray[tune], you're good to go with any pydantic version. autogen module is not updated in FLAML for a long time, if you need autogen, checkout microsoft/autogen repo. @OlivierBinette-UpStart |
@thinkall Oh you're totally right. We're using ray[tune], which is where the Pydantic dependency must be coming from. Do you think FLAML can be compatible with newer versions of Ray? |
The latest PR for supporting ray is #1392, but I'm not sure will it work for other modules or not. I think some changes will be needed. |
Why are these changes needed?
FLAML
currently uses a pinned version of Pydantic, version1.10.9
. This makes it impossible to installFLAML
alongside libraries that use other versions of Pydantic or Pydantic v2.Unclear why that limitation is required. Pydantic is only imported in a single place within the whole of the package.
Changes:
pydantic
to be compatible with both version 1 and version 2.Checks