Skip to content

Conversation

Sm1Ling
Copy link
Contributor

@Sm1Ling Sm1Ling commented Aug 23, 2025

Added closing of save_fds.

Why are these changes needed?

This change fixes bug mentioned in Issue #1454

Related issue number

Closes #1454

Checks

Actually, I haven't made any checks. Just fixed 2 lines of code

Added closing of save_fds.
@Sm1Ling Sm1Ling changed the title Update model.py Fix OSError: [Errno 24] Too many open files: 'nul' Aug 23, 2025
@thinkall
Copy link
Collaborator

Thank you so much for the PR, @Sm1Ling. Can you please fix the code format issue and the TypeError in the added code? Thanks.

image image

Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix the test errors? Thanks.

@Sm1Ling Sm1Ling requested a review from thinkall August 25, 2025 10:28
Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you so much, @Sm1Ling !

@thinkall thinkall merged commit d4e43c5 into microsoft:main Aug 26, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: OSError: [Errno 24] Too many open files: 'nul' after frequent AutoML fit

2 participants