[cmake] switch to FindCUDAToolkit#6457
Conversation
jameslamb
left a comment
There was a problem hiding this comment.
Thank you so much for this! I strongly support this change.
As it says in https://cmake.org/cmake/help/latest/module/FindCUDA.html
To find and use the CUDA toolkit libraries manually, use the FindCUDAToolkit module instead [of
FindCUDA]. It works regardless of the CUDA language being enabled.
|
Double-checked the build logs and this looks like it's working great. Based on that, all the other passing CI, and my own understanding of @shiyu1994 if you come back to this and disagree please let me know and we can change / revert it before the release (#6439). |
|
@characat0 thanks again, come back and contribute any time! |
|
Thanks for remembering @jameslamb, always a pleasure |
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
Cmake 3.17 introduced FindCUDAToolkit and deprecated FindCUDA, when cross compiling on linux, we found some weird behaviour, like having to run two or even three configure steps (JuliaPackaging/Yggdrasil#8593 with LightGBM for Julia) (JuliaPackaging/Yggdrasil#4554 (comment), Torch had the same issue).
Switching to FindCUDAToolkit should make this easier.