Skip to content

[c++] Add bounds check in StringToArrayFast() to prevent heap buffer over-read #6998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanjay20m wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −0
Open

[c++] Add bounds check in StringToArrayFast() to prevent heap buffer over-read #6998

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e06f11
[security] Add bounds check in StringToArrayFast() to prevent heap bu…
sanjay20m Aug 11, 2025
1d4e0f2
Merge branch 'master' into patch-4
sanjay20m Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions include/LightGBM/utils/common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,9 +489,14 @@ inline static std::vector<T> StringToArrayFast(const std::string& str, int n) {
return std::vector<T>();
}
auto p_str = str.c_str();
auto p_end = p_str + str.size();
__StringToTHelperFast<T, std::is_floating_point<T>::value> helper;
std::vector<T> ret(n);
for (int i = 0; i < n; ++i) {
p_str = Common::SkipSpaceAndTab(p_str);
if (p_str >= p_end) {
Log::Fatal("Malformed model file: not enough values in string for array of size %d", n);
}
p_str = helper(p_str, &ret[i]);
}
return ret;
Expand Down
Loading