-
Notifications
You must be signed in to change notification settings - Fork 4k
[ci] [swig] move SWIG jobs to GitHub Actions #7024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| cd "${BUILD_DIRECTORY}" | ||
|
|
||
| if [[ $TASK == "swig" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving this up avoids the need to set conda and Python-related environment variables in swig.yml
StrikerRUS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great but there are merge conflicts with other Azure-transferred jobs. Could you please resolve them? Also, I've added some comments mostly for the consistency with other recently merged PRs.
Co-authored-by: Nikita Titov <[email protected]>
|
Ah, some new conflicts after #7033 😢 |
|
Ah yep there will be a few merge conflicts as we go through these. I still think it's worthwhile to do in smaller, easier-to-review patches like this. And the new structure with dedicated workflow files for different types of jobs should hopefully mean fewer merge conflicts if we need to do this type of thing again in the future. I've resolved conflicts for this PR. |
StrikerRUS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Thanks a lot for preparing such comfortable to review series of PRs!
Done. |
Contributes to #6949 and #5035
Proposes moving SWIG jobs to GitHub Actions.
Notes for Reviewers
Branch protections will need to be updated
If this PR is accepted and merged, I'll updated the branch protections so this new
swigGitHub Actions workflow is required for PRs.But what about release artifacts?
Here I'm proposing that artifacts be uploaded to the GitHub Actions artifact store.
See e.g. https://github.com/microsoft/LightGBM/actions/runs/17691426641
Once all CI is moved over, we can figure out how to replace the functionality of "automatically upload all artifacts to the release" that we currently have with Azure DevOps. I think we can use the GitHub CLI for that (e.g.
gh run downloadto get artifacts,gh release uploadto push artifacts).