Skip to content

[python-package] fix test_numeric_split_direction to test all parameter combinations #7131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wagner-austin wants to merge 3 commits into
base: master
Choose a base branch
from
+6 −3
Open

[python-package] fix test_numeric_split_direction to test all parameter combinations #7131

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
596110f
[python-package] fix test_numeric_split_direction to test all paramet…
wagner-austin Jan 18, 2026
37706a1
Merge branch 'master' into fix-numeric-split-direction-test
jameslamb Jan 18, 2026
3d50d15
Merge branch 'master' into fix-numeric-split-direction-test
StrikerRUS Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tests/python_package_test/test_plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,6 @@ def test_tree_with_categories_above_max_category_values(tmp_path):
@pytest.mark.parametrize("use_missing", [True, False])
@pytest.mark.parametrize("zero_as_missing", [True, False])
def test_numeric_split_direction(use_missing, zero_as_missing):
if use_missing and zero_as_missing:
pytest.skip("use_missing and zero_as_missing both set to True")
X, y = make_synthetic_regression()
rng = np.random.RandomState(0)
zero_mask = rng.rand(X.shape[0]) < 0.05
Expand Down Expand Up @@ -363,7 +361,12 @@ def test_numeric_split_direction(use_missing, zero_as_missing):
)
node = node["left_child"] if direction == "left" else node["right_child"]
assert node["leaf_index"] == expected_leaf_nan
assert expected_leaf_zero != expected_leaf_nan
if zero_as_missing:
# zeros treated as missing -> same leaf as NaN
assert expected_leaf_zero == expected_leaf_nan
else:
# zeros are regular values -> different leaf from NaN
assert expected_leaf_zero != expected_leaf_nan


@pytest.mark.skipif(not GRAPHVIZ_INSTALLED, reason="graphviz is not installed")
Expand Down
Loading