[c++] Handle connection-closed socket errors gracefully #7139
+35
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During distributed training shutdown, workers may close connections at different times, causing EPIPE or ECONNRESET errors. Previously these caused fatal crashes via Log::Fatal. Now these expected errors are handled gracefully by returning SOCKET_ERROR to let callers clean up. See microsoft#4074
wagner-austin
requested review from
StrikerRUS,
borchero,
guolinke,
jameslamb,
jmoralez and
shiyu1994
as code owners
Contributor
Author
|
Closing - submitted prematurely. Will re-submit after verifying CI on fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During distributed training shutdown (especially with Dask), workers may close connections at different times. When one worker tries to send/receive on a socket that the peer has already closed, it gets EPIPE (code 32) or ECONNRESET (code 54/104) errors. Previously these caused fatal crashes via
Log::Fatal.This PR makes these expected shutdown errors non-fatal by returning
SOCKET_ERRORinstead, allowing callers to handle cleanup gracefully.Changes
IsConnectionClosedError()helper function to identify connection-closed error codes (EPIPE, ECONNRESET, ENOTCONN, ESHUTDOWN on POSIX; WSAECONNRESET, WSAECONNABORTED, WSAESHUTDOWN, WSAENOTCONN on Windows)TcpSocket::Send()andTcpSocket::Recv()to returnSOCKET_ERRORfor these errors instead of callingLog::FatalRelated Issue
Fixes #4074
Test Plan