-
Notifications
You must be signed in to change notification settings - Fork 4k
[python-package] Add tests for some plotting functions #7144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[python-package] Add tests for some plotting functions #7144
Conversation
@microsoft-github-policy-service agree |
jameslamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eb4dbfd to
1bc0e65
Compare
Alright, all unrelated formatting changes has been reverted and branch updated to the latest |
jameslamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I left some suggestions for making these tests a bit stronger.
xlim/ylim and max_num_features parameters|
I've updated the description and title, removing references to tests that you've since removed. It would be ok to add back |
1b55e96 to
6e14ae1
Compare
Thanks for clarifying and for updating the title. I'll add |
Contributes to #7031 by expanding test coverage for plotting module parameters.
New tests added:
plot_importance()max_num_featuresplot_split_value_histogram()xlimplot_metric()xlimTest plan
pytest tests/python_package_test/test_plotting.py::test_plot_importancepassespytest tests/python_package_test/test_plotting.py::test_plot_split_value_histogrampassespytest tests/python_package_test/test_plotting.py::test_plot_metricspasses