Skip to content

[python-package] removed _json_default_with_numpy private function #7145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daguirre11 wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −17
Open

[python-package] removed _json_default_with_numpy private function #7145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions python-package/lightgbm/basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,16 +527,6 @@ def _c_array(ctype: type, values: List[Any]) -> ctypes.Array:
return (ctype * len(values))(*values) # type: ignore[operator]


def _json_default_with_numpy(obj: Any) -> Any:
"""Convert numpy classes to JSON serializable objects."""
if isinstance(obj, (np.integer, np.floating, np.bool_)):
return obj.item()
elif isinstance(obj, np.ndarray):
return obj.tolist()
else:
return obj


def _to_string(x: Union[int, float, str, List]) -> str:
if isinstance(x, list):
val_list = ",".join(str(val) for val in x)
Expand Down Expand Up @@ -872,7 +862,7 @@ def _dump_pandas_categorical(
pandas_categorical: Optional[List[List]],
file_name: Optional[Union[str, Path]] = None,
) -> str:
categorical_json = json.dumps(pandas_categorical, default=_json_default_with_numpy)
categorical_json = json.dumps(pandas_categorical)
pandas_str = f"\npandas_categorical:{categorical_json}\n"
if file_name is not None:
with open(file_name, "a") as f:
Expand Down Expand Up @@ -4679,12 +4669,7 @@ def dump_model(
)
)
ret = json.loads(string_buffer.value.decode("utf-8"), object_hook=object_hook)
ret["pandas_categorical"] = json.loads(
json.dumps(
self.pandas_categorical,
default=_json_default_with_numpy,
)
)
ret["pandas_categorical"] = json.loads(json.dumps(self.pandas_categorical))
return ret

def predict(
Expand Down
Loading