Skip to content

CI fixups - #508

Merged
Brian Kroth (bpkroth) merged 15 commits into
microsoft:mainfrom
bpkroth:licenseheader-rule-fixups
Sep 18, 2023
Merged

CI fixups#508
Brian Kroth (bpkroth) merged 15 commits into
microsoft:mainfrom
bpkroth:licenseheader-rule-fixups

Conversation

@bpkroth

@bpkroth Brian Kroth (bpkroth) commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

@bpkroth
Brian Kroth (bpkroth) requested a review from a team as a code owner September 14, 2023 18:52
Comment thread Makefile
Comment thread .github/workflows/devcontainer.yml
@bpkroth
Brian Kroth (bpkroth) enabled auto-merge (squash) September 14, 2023 19:14
@bpkroth Brian Kroth (bpkroth) added the ready for review Ready for review label Sep 14, 2023

@motus Sergiy Matusevych (motus) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@bpkroth
Brian Kroth (bpkroth) merged commit d2aa3a6 into microsoft:main Sep 18, 2023
Brian Kroth (bpkroth) added a commit that referenced this pull request Sep 18, 2023
Handles bugs from #508.

Also try and fix a quoting issues.
Brian Kroth (bpkroth) added a commit to bpkroth/MLOS that referenced this pull request Sep 19, 2023
Brian Kroth (bpkroth) added a commit that referenced this pull request Sep 20, 2023
One more minor tweak on #509 and #508. This allows us to force a rebuild
of the devcontainer with NO_CACHE=true manually without needing to push
an empty commit.
@bpkroth
Brian Kroth (bpkroth) deleted the licenseheader-rule-fixups branch October 10, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants