Skip to content

Fixups to commit message checks to only happen during PR pushes #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brian Kroth (bpkroth) merged 8 commits into from
Sep 18, 2023
Merged

Fixups to commit message checks to only happen during PR pushes #509

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7948904
Fixups to commit message checks to only happen during PR pushes
bpkroth Sep 18, 2023
7eda30f
wrong event type for action condition for NO_CACHE=true checks
bpkroth Sep 18, 2023
ead01ea
more debug logging
bpkroth Sep 18, 2023
41201e2
switch event name back
bpkroth Sep 18, 2023
46e71da
more debug logging
bpkroth Sep 18, 2023
e864935
fixups
bpkroth Sep 18, 2023
2d89c9d
empty commit with spaces in the message
bpkroth Sep 18, 2023
0a10a9b
another - commit message - with NO_CACHE=true
bpkroth Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/devcontainer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,17 @@ jobs:

- name: Get commit messages
id: get-commit-messages
if: github.event_name == 'pull_request'
run: |
# Only look at the last 10 commits, to avoid getting too much data.
# If the message wasn't in there (e.g. because the push was a merge and too large), then we just ignore it.
git fetch --deepen=10
git log --format="%B" -10 ${{ github.event.before }}..${{ github.event.after }} > /tmp/commit_messages.txt || true
echo "COMMIT_MESSAGES=$(cat /tmp/commit_messages.txt)" >> $GITHUB_OUTPUT
# Handle multiline output:
{
echo 'COMMIT_MESSAGES<<COMMIT_MESSAGES_EOF'
git log --format="%B" -10 ${{ github.event.before }}..${{ github.event.after }} | tee /tmp/commit_messages.txt
echo COMMIT_MESSAGES_EOF
} >> $GITHUB_OUTPUT

- name: Set NO_CACHE variable based on commit messages and for nightly builds
if: github.event_name == 'schedule' || contains(steps.get-commit-messages.outputs.COMMIT_MESSAGES, 'NO_CACHE=true')
Expand All @@ -46,6 +51,9 @@ jobs:
set -x
printenv
echo "NO_CACHE: ${NO_CACHE:-}"
echo "EVENT_NAME: ${{ github.event_name }}"
echo "BEFORE: ${{ github.event.before }}"
echo "AFTER: ${{ github.event.after }}"
echo "COMMIT_MESSAGES: ${{ steps.get-commit-messages.outputs.COMMIT_MESSAGES }}"
echo "COMMIT_SHA: ${{ github.sha }}"
echo "git log -1 ${{ github.sha }}: $(git log -1 ${{ github.sha }})"
Expand Down