Skip to content

Commit 7919493

Browse files
authored
Merge pull request #9420 from MaxWang-MS/su_remove_dependency
Remove dotnetwinrt dependency in Scene Understanding
2 parents 0747f84 + 8dea9e4 commit 7919493

File tree

5 files changed

+13
-19
lines changed

5 files changed

+13
-19
lines changed

Assets/MRTK/Examples/Experimental/SceneUnderstanding/Scenes/SceneUnderstandingExample.unity

+7-7
Original file line numberDiff line numberDiff line change
@@ -4926,17 +4926,17 @@ PrefabInstance:
49264926
- target: {fileID: 2113875699234556495, guid: 18470d71939382448be2ecd06efa9662,
49274927
type: 3}
49284928
propertyPath: m_textInfo.characterCount
4929-
value: 541
4929+
value: 523
49304930
objectReference: {fileID: 0}
49314931
- target: {fileID: 2113875699234556495, guid: 18470d71939382448be2ecd06efa9662,
49324932
type: 3}
49334933
propertyPath: m_textInfo.spaceCount
4934-
value: 76
4934+
value: 73
49354935
objectReference: {fileID: 0}
49364936
- target: {fileID: 2113875699234556495, guid: 18470d71939382448be2ecd06efa9662,
49374937
type: 3}
49384938
propertyPath: m_textInfo.wordCount
4939-
value: 76
4939+
value: 73
49404940
objectReference: {fileID: 0}
49414941
- target: {fileID: 2113875699234556495, guid: 18470d71939382448be2ecd06efa9662,
49424942
type: 3}
@@ -4961,10 +4961,10 @@ PrefabInstance:
49614961
49624962
<size=24><b>Important - Required packages</b></size>
49634963
4964-
Use MixedReality Feature Tool to get the Dot Net WinRT and Scene Understanding
4965-
packages. The Scene Understanding package may not be available at MRTK 2.6
4966-
launch time but will be released soon after. Please check issue #9402 on the
4967-
MRTK-Unity GitHub repository for updates on its availability.'
4964+
Use Mixed Reality Feature Tool to get the Scene Understanding package. The
4965+
Scene Understanding package may not be available at MRTK 2.6 launch time but
4966+
will be released soon after. Please check issue #9402 on the MRTK-Unity GitHub
4967+
repository for updates on its availability.'
49684968
objectReference: {fileID: 0}
49694969
- target: {fileID: 2113875699234556495, guid: 18470d71939382448be2ecd06efa9662,
49704970
type: 3}

Assets/MRTK/Providers/Experimental/WindowsSceneUnderstanding/WindowsSceneUnderstandingObserver.cs

+2-10
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
#if WINDOWS_UWP
1818
using Windows.Perception.Spatial;
1919
using Windows.Perception.Spatial.Preview;
20-
#else
21-
using Microsoft.Windows.Perception.Spatial;
22-
using Microsoft.Windows.Perception.Spatial.Preview;
2320
#endif // WINDOWS_UWP
2421
using UnityEngine.Assertions;
2522
using UnityEngine.EventSystems;
@@ -766,12 +763,7 @@ private async Task RunObserverAsync(CancellationToken cancellationToken)
766763
private System.Numerics.Matrix4x4 GetSceneToWorldTransform()
767764
{
768765
var result = System.Numerics.Matrix4x4.Identity;
769-
770-
if (Application.isEditor)
771-
{
772-
return result;
773-
}
774-
766+
#if WINDOWS_UWP
775767
SpatialCoordinateSystem sceneOrigin = SpatialGraphInteropPreview.CreateCoordinateSystemForNode(sceneOriginId);
776768
SpatialCoordinateSystem worldOrigin = WindowsMixedReality.WindowsMixedRealityUtilities.SpatialCoordinateSystem;
777769

@@ -781,7 +773,7 @@ private System.Numerics.Matrix4x4 GetSceneToWorldTransform()
781773
{
782774
result = sceneToWorld.Value; // numerics
783775
}
784-
776+
#endif
785777
return result;
786778
}
787779

Assets/MRTK/Tools/MSBuild/Scripts/UnityProjectInfo.cs

+2
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ public class UnityProjectInfo
2727
"LeapMotion",
2828
"LeapMotion.LeapCSharp",
2929
"Microsoft.MixedReality.Toolkit.PlaneFinding",
30+
"Microsoft.MixedReality.SceneUnderstanding.Projections.Editor",
31+
"Microsoft.MixedReality.SceneUnderstanding.Projections.WSA",
3032
#if UNITY_2019_3_OR_NEWER
3133
"Oculus.VR",
3234
"Oculus.VR.Editor",

pipelines/config/settings.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ variables:
44
Unity2019Version: Unity2019.4.8f1
55
# Unity version on internal build agents (release builds)
66
Unity2018VersionInternal: Unity2018.4.23f1
7-
Unity2019VersionInternal: Unity2019.4.6f1
7+
Unity2019VersionInternal: Unity2019.4.17f1
88
Unity2020VersionInternal: Unity2020.2.2f1
99

1010
# Note that when updating this value also ensure that you update the

pipelines/docs-binaries.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ jobs:
6666

6767
- job: BuildUnity2018
6868
pool:
69-
name: Analog On-Prem
69+
name: Analog N-1
7070
demands:
7171
- ${{ variables.Unity2018VersionInternal }}
7272
- COG-UnityCache-WUS2-01

0 commit comments

Comments
 (0)