Skip to content
This repository was archived by the owner on Dec 22, 2020. It is now read-only.

Conversation

@lipp
Copy link
Contributor

@lipp lipp commented Apr 7, 2017

  • add typings, typescript as dev deps
  • use prepublish script (standard hook) instead of contrib + precontrib

prepublish is a standard hook that gets executed automatically after npm i.
It is also automatically executed during npm publish.

@ali-hamud ali-hamud self-requested a review April 16, 2017 08:32
"scripts": {
"precontrib": "npm install -g typings typescript && npm install",
"contrib": "typings install && tsc"
"prepublish": "typings install && tsc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calling tsc after installing it via devDependencies does not work for me.
am I missing something here? maybe it worked for you because you have typescript installed globally?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsc is important for incremental build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll check it out...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants