ConnectWise PSA (Independent Publisher) #3714
Conversation
|
@microsoft-github-policy-service agree [company="Opal Business Solutions, Inc."]
On Monday, November 18, 2024 at 03:03:14 PM EST, microsoft-github-policy-service[bot] ***@***.***> wrote:
@howellchrisj please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:
- (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
- (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement
Contribution License Agreement
This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.
- Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
- Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
- Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
- Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
- Licenses.
- Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
- Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
- Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.
- Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
- Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
- Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
- Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
- Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@microsoft-github-policy-service agree company="Opal Business Solutions"
On Monday, November 18, 2024 at 03:23:03 PM EST, microsoft-github-policy-service[bot] ***@***.***> wrote:
@howellchrisj the command you issued was incorrect. Please try again.
Examples are:
@microsoft-github-policy-service agree
and
@microsoft-github-policy-service agree company="your company"
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
howellchrisj
changed the title
There was a problem hiding this comment.
Hello @howellchrisj,
Thank you for submitting your connector. However the artifacts are not as expected. Kindly follow below links and submit your connector artifacts.
Independent Publisher Template - https://github.com/microsoft/PowerPlatformConnectors/tree/dev/templates/Independent%20Publisher
Independent Publisher Certification Process - https://learn.microsoft.com/en-us/connectors/custom-connectors/certification-submission-ip
howellchrisj
changed the title
|
Hello @howellchrisj, the files names are not as expected. Kindly follow the templates in the below link and submit the files. https://github.com/microsoft/PowerPlatformConnectors?tab=readme-ov-file https://github.com/microsoft/PowerPlatformConnectors/tree/dev/templates/Independent%20Publisher
|
…endent Publisher)/apiDefinition.swagger.json
|
I renamed the json file, but I can't seem to understand what other naming is not correct. The documentation says to upload screenshots of proof the connector works, but if there is a certain name the screenshots need to be, I can't seem to find them. Also, the README.md is what is in the template, but I also see a readme.md, which if it is lowercase vs. uppercase, let me know which is correct.
Thank you.
On Thursday, November 28, 2024 at 11:13:14 AM EST, vmanoharas ***@***.***> wrote:
Hello @howellchrisj,
the files names are not as expected. Kindly follow the templates in the below link and submit the files.
https://github.com/microsoft/PowerPlatformConnectors?tab=readme-ov-file
https://github.com/microsoft/PowerPlatformConnectors/tree/dev/templates/Independent%20Publisher
image.png (view on web)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Hello @howellchrisj, The screenshots to be uploaded here in the comments section, please remove them from the connector artifacts. Please add only below files except the independent-publisher-icon.png file.
|
…endent Publisher)/independent-publisher-icon.png
…endent Publisher)/ConnectWise API Connector 1.png
…endent Publisher)/ConnectWise API Connector 2.png
|
|
|
|
There was a problem hiding this comment.
Hello @howellchrisj,
Please address the review comments and fix the below swagger validation errors.
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01company1companies1{id}/patch/parameters/1
##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01company1companies1{id}/patch/parameters/1
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01company1companies1{id}/patch/parameters/2
##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01company1companies1{id}/patch/parameters/2
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/get/parameters/0
##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/get/parameters/0
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/get/parameters/1
##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/get/parameters/1
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/get/parameters/2
##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/get/parameters/2
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/patch/parameters/0
##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/patch/parameters/0
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/patch/parameters/1
##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/patch/parameters/1
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/patch/parameters/2
##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/patch/parameters/2
##[error]The 'contact' property is required. ValuePath: /info
##[error]The 'x-ms-connector-metadata' property is required.
independent-publisher-connectors/Proposal - ConnectWise (Independent Publisher)/README.md
Outdated
Show resolved
Hide resolved
...blisher-connectors/Proposal - ConnectWise (Independent Publisher)/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
|
Hello @howellchrisj, The swagger validation is still failing. Kindly fix the below errors. ##[error]The 'description' property is required. ValuePath: /paths/ |
|
@vmanoharas, an updated file has been uploaded with what I believe are the changes requested. |
|
Hello @howellchrisj, Thank you for fixing all the issues, however there is one move error mentioned below, kindly fix this. The 'x-ms-connector-metadata' property is required. Additionally, rename folder without "Proposal".
|
Added Metadata section
…endent Publisher)/apiProperties.json
…endent Publisher)/README.md
…endent Publisher)/apiDefinition.swagger.json
|
Metadata section added and renamed the folder. |
|
Hello @howellchrisj, You have added two Readme.md files to files, please see the screen shot below. Additionally the folder structure is in correct.
Also please refer the below screen shots the for your reference for folder structure.
|
|
@vmanoharas, I removed the Readme file that was outside the PSA folder. As for the folder structure being incorrect, can you please supply some details? |
There was a problem hiding this comment.
Dear Partner
I hope you are doing well.
Congratulations, your pull request is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 5-6 weeks.
Please let us know if you have any questions.
Thank you very much for working with us.
|
Hello Partner, |
|
I am curious, why is the API Key not available to be populated within the connection?
On Tuesday, February 25, 2025 at 09:51:40 AM EST, vmanoharas ***@***.***> wrote:
Merged #3714 into dev.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I'm not sure how you created the apiProperties file, but it is missing the API Key as a connection parameter: |
|
@troystaylor , thank you for the insight, I have made the change to the file. I read through the documentation, it just says I can directly post to dev, I assume the changes are being picked up and reviewed as normal and will be merged into the main branch periodically? |
When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
apiDefinition.swagger.json, by runningpaconn validatecommand.apiProperties.jsonhas a valid brand color and doesn't use an invalid brand color,#007ee5or#ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process: