Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectWise PSA (Independent Publisher) #3714

Merged
merged 27 commits into from
Feb 25, 2025
Merged

Conversation

howellchrisj
Copy link
Contributor

@howellchrisj howellchrisj commented Nov 18, 2024


When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

@howellchrisj howellchrisj requested a review from a team as a code owner November 18, 2024 19:59
@howellchrisj
Copy link
Contributor Author

howellchrisj commented Nov 18, 2024 via email

@howellchrisj
Copy link
Contributor Author

howellchrisj commented Nov 18, 2024 via email

@howellchrisj howellchrisj changed the title Proposal - ConnectWise (Independent Publisher) ConnectWise (Independent Publisher) Nov 18, 2024
Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @howellchrisj,

Thank you for submitting your connector. However the artifacts are not as expected. Kindly follow below links and submit your connector artifacts.

Independent Publisher Template - https://github.com/microsoft/PowerPlatformConnectors/tree/dev/templates/Independent%20Publisher

Independent Publisher Certification Process - https://learn.microsoft.com/en-us/connectors/custom-connectors/certification-submission-ip

@howellchrisj howellchrisj changed the title ConnectWise (Independent Publisher) ConnectWise PSA (Independent Publisher) Nov 22, 2024
@vmanoharas
Copy link
Contributor

Hello @howellchrisj,

the files names are not as expected. Kindly follow the templates in the below link and submit the files.

https://github.com/microsoft/PowerPlatformConnectors?tab=readme-ov-file

https://github.com/microsoft/PowerPlatformConnectors/tree/dev/templates/Independent%20Publisher

image

@howellchrisj
Copy link
Contributor Author

howellchrisj commented Nov 28, 2024 via email

@vmanoharas
Copy link
Contributor

Hello @howellchrisj,

The screenshots to be uploaded here in the comments section, please remove them from the connector artifacts.
image

Please add only below files except the independent-publisher-icon.png file.

image

@howellchrisj
Copy link
Contributor Author

ConnectWise API Connector 1

@howellchrisj
Copy link
Contributor Author

ConnectWise API Connector 2

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @howellchrisj,

Please address the review comments and fix the below swagger validation errors.

##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01company1companies1{id}/patch/parameters/1

##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01company1companies1{id}/patch/parameters/1

##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01company1companies1{id}/patch/parameters/2

##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01company1companies1{id}/patch/parameters/2

##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/get/parameters/0

##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/get/parameters/0

##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/get/parameters/1

##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/get/parameters/1

##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/get/parameters/2

##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/get/parameters/2

##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/patch/parameters/0

##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/patch/parameters/0

##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/patch/parameters/1

##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/patch/parameters/1

##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/patch/parameters/2

##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/patch/parameters/2

##[error]The 'contact' property is required. ValuePath: /info

##[error]The 'x-ms-connector-metadata' property is required.

@vmanoharas
Copy link
Contributor

Hello @howellchrisj,

The swagger validation is still failing. Kindly fix the below errors.

##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/get/parameters/0
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/get/parameters/1
##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/get/parameters/1
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/get/parameters/2
##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/get/parameters/2
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/patch/parameters/0
##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/patch/parameters/0
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/patch/parameters/1
##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/patch/parameters/1
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/patch/parameters/2
##[error]The 'description' property is required. ValuePath: /paths/1v4_6_release1apis13.01service1tickets1{id}/patch/parameters/2
##[error]The 'contact' property is required. ValuePath: /info

@howellchrisj
Copy link
Contributor Author

howellchrisj commented Dec 11, 2024

@vmanoharas, an updated file has been uploaded with what I believe are the changes requested.

@vmanoharas
Copy link
Contributor

Hello @howellchrisj,

Thank you for fixing all the issues, however there is one move error mentioned below, kindly fix this.

The 'x-ms-connector-metadata' property is required.

Additionally, rename folder without "Proposal".

image

@howellchrisj
Copy link
Contributor Author

Metadata section added and renamed the folder.

@vmanoharas
Copy link
Contributor

Hello @howellchrisj,

You have added two Readme.md files to files, please see the screen shot below. Additionally the folder structure is in correct.

image

Also please refer the below screen shots the for your reference for folder structure.

image

@howellchrisj
Copy link
Contributor Author

howellchrisj commented Jan 10, 2025

@vmanoharas, I removed the Readme file that was outside the PSA folder. As for the folder structure being incorrect, can you please supply some details?

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Partner

I hope you are doing well.
Congratulations, your pull request is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 5-6 weeks.
Please let us know if you have any questions.
Thank you very much for working with us.

@vmanoharas
Copy link
Contributor

Hello Partner,
I hope you are doing well.
Congratulations, the deployment of your connector and documentation page was already completed, We have a short survey - https://forms.office.com/Pages/ResponsePage.aspx?id=v4j5cvGGr0GRqy180BHbR0BHMrjhL0hDmckROosW6AFURERIVUUzMk5XRzJGV1dJM1Q5RVZJUjFXSC4u on the connector certification process that we would like for you to complete. Your feedback is appreciated and will help us improve the program.
Thank you very much for working with us.

@vmanoharas vmanoharas merged commit ebb752a into microsoft:dev Feb 25, 2025
1 check passed
@howellchrisj
Copy link
Contributor Author

howellchrisj commented Feb 25, 2025 via email

@troystaylor
Copy link
Contributor

I am curious, why is the API Key not available to be populated within the connection? On Tuesday, February 25, 2025 at 09:51:40 AM EST, vmanoharas @.> wrote: Merged #3714 into dev. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.>

I'm not sure how you created the apiProperties file, but it is missing the API Key as a connection parameter:
msedge_TKjc2jarCD

@howellchrisj
Copy link
Contributor Author

@troystaylor , thank you for the insight, I have made the change to the file. I read through the documentation, it just says I can directly post to dev, I assume the changes are being picked up and reviewed as normal and will be merged into the main branch periodically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants