-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabscanner Receipt OCR (Independent Publisher) #3756
base: dev
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree company="Tabscanner" |
@v-alisancic can anyone assist with this review please? Thank you! |
Hello @tokyoben, Could you please correct the folder structure before proceeding for the review? |
Hi @vmanoharas thank you for finding this, i have corrected the file structure |
@vmanoharas any update on this? thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tokyoben,
Please address review comments.
independent-publisher-connectors/Tabscanner Receipt OCR/readme.md
Outdated
Show resolved
Hide resolved
independent-publisher-connectors/Tabscanner Receipt OCR/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
independent-publisher-connectors/Tabscanner Receipt OCR/apiProperties.json
Outdated
Show resolved
Hide resolved
Hi @vmanoharas I have made the requested changes. Thank you! |
Hi @vmanoharas were these adjustments ok? let me know if there is anything else I need to update. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tokyoben,
Could you please resolve review comment?
independent-publisher-connectors/Tabscanner Receipt OCR/apiDefinition.swagger.json
Show resolved
Hide resolved
Hi @vmanoharas fixed and resolved comment, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear Partner
I hope you are doing well.
Congratulations, your pull request is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 3-4 weeks.
Please let us know if you have any questions.
Thank you very much for working with us.
38dfe29
to
51a737c
Compare
Hi @vmanoharas I am seeing a message "Merging is blocked Merge is not an allowed merge method in this repository.This branch must not contain merge commits.", I have synced my branch so should merge now, thank you for your help on this! |
When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
apiDefinition.swagger.json
, by runningpaconn validate
command.apiProperties.json
has a valid brand color and doesn't use an invalid brand color,#007ee5
or#ffffff
. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process: