Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabscanner Receipt OCR (Independent Publisher) #3756

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

tokyoben
Copy link


When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.
Screenshot 2025-01-15 at 18 36 14 Screenshot 2025-01-15 at 18 32 13

@tokyoben tokyoben requested a review from a team as a code owner January 15, 2025 09:38
@tokyoben
Copy link
Author

@microsoft-github-policy-service agree company="Tabscanner"

@tokyoben
Copy link
Author

@v-alisancic can anyone assist with this review please? Thank you!

@vmanoharas
Copy link
Contributor

Hello @tokyoben,

Could you please correct the folder structure before proceeding for the review?

image

@tokyoben
Copy link
Author

Hi @vmanoharas thank you for finding this, i have corrected the file structure

@tokyoben
Copy link
Author

@vmanoharas any update on this? thank you!

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tokyoben,

Please address review comments.

@tokyoben
Copy link
Author

tokyoben commented Feb 3, 2025

Hi @vmanoharas I have made the requested changes. Thank you!

@tokyoben
Copy link
Author

Hi @vmanoharas were these adjustments ok? let me know if there is anything else I need to update. Thank you!

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tokyoben,

Could you please resolve review comment?

@tokyoben
Copy link
Author

Hello @tokyoben,

Could you please resolve review comment?

Hi @vmanoharas fixed and resolved comment, thanks!

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Partner

I hope you are doing well.
Congratulations, your pull request is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 3-4 weeks.
Please let us know if you have any questions.
Thank you very much for working with us.

adds files for Tabscanner connector

updates metadata

correct file struture

Delete independent-publisher-connectors/.DS_Store

corrects file structure

corrects readme description, shortens parameter descriptions and updates icon brand color

adds x-ms-summary for token parameter
@tokyoben tokyoben force-pushed the feature/tabscanner-receipt-ocr branch from 38dfe29 to 51a737c Compare February 19, 2025 22:31
@tokyoben
Copy link
Author

tokyoben commented Feb 19, 2025

Dear Partner

I hope you are doing well. Congratulations, your pull request is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 3-4 weeks. Please let us know if you have any questions. Thank you very much for working with us.

Hi @vmanoharas I am seeing a message "Merging is blocked Merge is not an allowed merge method in this repository.This branch must not contain merge commits.", I have synced my branch so should merge now, thank you for your help on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants