Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEMA (Independent Publisher) #3769

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

FEMA (Independent Publisher) #3769

wants to merge 5 commits into from

Conversation

troystaylor
Copy link
Contributor

brave_SlX1Zut3Ic
brave_a68Az5FroH

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

@troystaylor troystaylor requested a review from a team as a code owner January 29, 2025 22:10
vmanoharas
vmanoharas reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @troystaylor,

Can you please address the review comments?

independent-publisher-connectors/FEMA/apiDefinition.swagger.json
"x-ms-summary": "GZip",
"required": false,
"type": "string",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this is "titbits"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this titbits or tidbits? if it is titbits, please change this

vmanoharas
vmanoharas reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @troystaylor,

Some more review comments, can you please resolve them?

independent-publisher-connectors/FEMA/apiDefinition.swagger.json
"x-ms-summary": "GZip",
"required": false,
"type": "string",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this typo is still exist, please correct this

independent-publisher-connectors/FEMA/apiDefinition.swagger.json Outdated
"x-ms-summary": "GZip",
"required": false,
"type": "string",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This typo is still exist, can you please correct this?

independent-publisher-connectors/FEMA/apiDefinition.swagger.json Outdated
"x-ms-summary": "GZip",
"required": false,
"type": "string",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not corrected yet, can you please correct this?

vmanoharas
vmanoharas reviewed Feb 21, 2025
View reviewed changes
Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @troystaylor,

Some comments are not resolved yet, could you please address them?

independent-publisher-connectors/FEMA/apiDefinition.swagger.json Outdated
"x-ms-summary": "GZip",
"required": false,
"type": "string",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please correct this typo "idenify"

independent-publisher-connectors/FEMA/apiDefinition.swagger.json Outdated
"x-ms-summary": "GZip",
"required": false,
"type": "string",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please correct the typo "relaled"

independent-publisher-connectors/FEMA/apiDefinition.swagger.json
"x-ms-summary": "GZip",
"required": false,
"type": "string",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this titbits or tidbits? if it is titbits, please change this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmanoharas vmanoharas Awaiting requested review from vmanoharas

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@troystaylor @vmanoharas