Skip to content

Finance Agents SAP BTP Connector (Independent Publisher) #3841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

kossevv
Copy link

@kossevv kossevv commented Apr 11, 2025


When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

изображение
изображение

@kossevv kossevv requested a review from a team as a code owner April 11, 2025 13:44
@kossevv kossevv changed the title Create intro.md Proposal - Finance Agents SAP BTP Connector (Independent Publisher) Apr 11, 2025
@kossevv
Copy link
Author

kossevv commented Apr 11, 2025

@microsoft-github-policy-service agree company="Accenture"

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kossevv,

Please remove Proposal word from the title and submit your files for review.

@kossevv kossevv changed the title Proposal - Finance Agents SAP BTP Connector (Independent Publisher) Finance Agents SAP BTP Connector (Independent Publisher) Apr 29, 2025
@kossevv kossevv requested a review from vmanoharas April 29, 2025 09:34
@vmanoharas
Copy link
Contributor

vmanoharas commented May 6, 2025

Hello @kossevv,

Please refer the below links and update your files to fix the swagger validation errors. The errors list huge, added few errors below.

[PowerPlatformConnectors/templates/certified-connectors/apiDefinition.swagger.json at dev · microsoft/PowerPlatformConnectors](https://github.com/microsoft/PowerPlatformConnectors/tree/dev/templates/Independent%20Publisher)

PowerPlatformConnectors/schemas/apiDefinition.swagger.schema.json at dev · microsoft/PowerPlatformConnectors

Follow coding standards | Microsoft Learn

##[error]The 'title' value goes over the character limit '30' ValuePath: /info/title
##[error]The 'description' property is required. ValuePath: /info
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/~1contacts/post/parameters/0
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/~1contacts/post/parameters/1
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1contacts1create/post/parameters/0
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1contacts1create/post/parameters/1
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1contacts1{contactId}/put/parameters/0
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1contacts1{contactId}/put/parameters/1
##[error]The 'description' property is required. ValuePath: /paths/1contacts1{contactId}/put/parameters/1
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1contacts1{contactId}/put/parameters/2
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/~1customers/post/parameters/0
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/~1customers/post/parameters/1
##[error]The 'description' property is required. ValuePath: /paths/~1customers/post/parameters/1

##[error]The 'description' property is required. ValuePath: /paths/~1customers/post/parameters/3
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/~1customers/post/parameters/4
##[error]The 'description' property is required. ValuePath: /paths/~1customers/post/parameters/4
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/~1customers/post/parameters/5
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/~1customers/post/parameters/6
##[error]The 'description' property is required. ValuePath: /paths/~1customers/post/parameters/6
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/~1customers/post/parameters/7
##[error]The 'description' property is required. ValuePath: /paths/~1customers/post/parameters/7
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/~1customers/post/parameters/8
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/~1customers/post/parameters/9
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/~1customers/post/parameters/10
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1customers1{customerId}~1accountstatement/get/parameters/0
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1customers1{customerId}~1accountstatement/get/parameters/1
##[error]The 'description' property is required. ValuePath: /paths/1customers1{customerId}~1accountstatement/get/parameters/1
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1customers1{customerId}~1accountstatement/get/parameters/2
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1customers1{customerId}~1activities/get/parameters/0
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1customers1{customerId}~1activities/get/parameters/1
##[error]The 'description' property is required. ValuePath: /paths/1customers1{customerId}~1activities/get/parameters/1
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1customers1{customerId}~1activities/get/parameters/2

##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1customers1{customerId}~1invoices/get/parameters/10
##[error]The 'description' property is required. ValuePath: /paths/1customers1{customerId}~1invoices/get/parameters/10
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1customers1{customerId}~1invoices/get/parameters/11
##[error]The 'description' property is required. ValuePath: /paths/1customers1{customerId}~1invoices/get/parameters/11
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1customers1{customerId}~1invoices/get/parameters/12
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1customers1{customerId}~1invoices/get/parameters/13
##[error]The 'description' property is required. ValuePath: /paths/1customers1{customerId}~1invoices/get/parameters/13
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1customers1{customerId}~1invoices/get/parameters/14

@kossevv
Copy link
Author

kossevv commented May 8, 2025

Dear @vmanoharas,
Corrected API definition is committed.
Cheers
Vassil

@vmanoharas
Copy link
Contributor

Hi @kossevv,

Thank you reducing the error count.

However, we have more swagger validation errors, we request you to please address them.

##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1contacts/post/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/1contacts1create/post/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/1contacts1{contactId}/put/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1customers/post/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/1customers1{customerId}~1accountstatement/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/1customers1{customerId}~1activities/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/1customers1{customerId}~1agedbalances/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/1customers1{customerId}~1invoicedocuments/post/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/1customers1{customerId}~1invoices/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/1invoices1statuses/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/1invoices1{invoiceId}~1status/put/responses/default
##[error]The 'contact' property is required. ValuePath: /info
##[error]The 'x-ms-connector-metadata' property is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants