Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FancyZones] Tests: FZEditor #32068

Open
wants to merge 79 commits into
base: main
Choose a base branch
from
Open

[FancyZones] Tests: FZEditor #32068

wants to merge 79 commits into from
+5,464 −257

Conversation

SeraphimaZykova
Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova commented Mar 25, 2024 •
edited
Loading

Summary of the Pull Request

Tests added:

  • Add test data and start → verify data is correct (custom layouts, template layouts, defaults, shortcut keys)
  • Create a new canvas - verify layout exists
  • Create a new canvas - cancel - doesn’t exist
  • Create a new grid - verify the layout exists
  • Create a new grid - cancel - doesn’t exist
  • Duplicate template by button (+ check default)
  • Duplicate template by menu (+ check default)
  • Duplicate custom by button (+ check shortcut key and default)
  • Duplicate custom by menu (+ check shortcut key and default)
  • Delete non-applied layout
  • Delete applied layout
  • Delete-cancel
  • Delete from context menu
  • Delete: hotkey released
  • Delete: default layout reset to default-default
  • Edit template and save
  • Edit template and cancel
  • Edit custom and save
  • Edit custom and cancel
  • Edit canvas: add zone
  • Edit canvas: delete zone
  • Edit canvas: move zone
  • Edit canvas: resize zone
  • Edit grid: split zone
  • Edit grid: merge zones
  • Edit grid: move splitter
  • UI Init: assigned layouts selected
  • UI Init: applied default - check params
  • UI Init: assigned custom layout, but id not found
  • Assign the same template but with different params to monitors
  • Assign layout on each monitor
  • Assign custom
  • Assign template
  • Assign shortcut key and save
  • Assign shortcut key and cancel
  • Reset shortcut key and save
  • Reset shortcut key and cancel
  • Set default layout + verify both prev and current after reopening
  • applied-layouts.json keeps info about not connected devices - verify they’re present after closing
  • applied-layouts.json keeps info about other virtual desktops
  • first launch without custom-layouts.json, default-layouts.json, layout-hotkeys.json and layout-templates.json

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@SeraphimaZykova
add name to monitors list
77ef982
@SeraphimaZykova
click item
ef35c5f
@SeraphimaZykova
click monitor test
8c8a06b
@SeraphimaZykova
added ui initialization tests
d6c744d
@SeraphimaZykova
moved enum
45bd2ad
@SeraphimaZykova
get zone slider
04e85d8
@SeraphimaZykova
save and cancel clicks
495fd38
@SeraphimaZykova
handy assert
9ee4970
@SeraphimaZykova
fix layout name
a5d6eae
@SeraphimaZykova
separate io helpers
8df25c1
@SeraphimaZykova
template zone number test
e7e0366
@SeraphimaZykova
accessibility ids
13dd37e
@SeraphimaZykova
wait
f06558d
@SeraphimaZykova
template layouts tests
becb361
@SeraphimaZykova
rename test class
bdf4429
@SeraphimaZykova
rename template layouts constants
4a7024b
@SeraphimaZykova
wait
9474a55
@SeraphimaZykova
replace assert when searching a layout
fc95971
@SeraphimaZykova
spelling
4fe650e
@SeraphimaZykova
custom layouts tests
c6db64b
@SeraphimaZykova
changed test initialization
9fc2b25
@SeraphimaZykova
fix name checks
c4a452e
@SeraphimaZykova
fix: restore name
d5ca870
@SeraphimaZykova
template layouts: save-cancel tests
634aa4f
@SeraphimaZykova
restore applied layouts
eced774
@SeraphimaZykova
custom layouts initialization
e090161
@SeraphimaZykova
restore applied layouts with editor params
bb36bf6
@SeraphimaZykova
log if element not displayed
cfb9a27
@SeraphimaZykova
always add "None" value
2334c7a
@SeraphimaZykova
rename context click
30c3df5
@crutkas crutkas mentioned this pull request Feb 14, 2025
Merged
Copilot
Copilot AI reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 22 out of 37 changed files in this pull request and generated 2 comments.

Files not reviewed (15)
  • src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml: Language not supported
  • src/modules/fancyzones/FancyZonesEditorCommon/Data/Constants.cs: Evaluated as low risk
  • src/modules/fancyzones/editor/FancyZonesEditor/LayoutBackup.cs: Evaluated as low risk
  • src/modules/fancyzones/editor/FancyZonesEditor/Converters/LayoutModelTypeBlankToVisibilityConverter.cs: Evaluated as low risk
  • src/modules/fancyzones/editor/FancyZonesEditor/Converters/LayoutTypeCustomToVisibilityConverter.cs: Evaluated as low risk
  • src/modules/fancyzones/editor/FancyZonesEditor/Converters/LayoutTypeTemplateToVisibilityConverter.cs: Evaluated as low risk
  • src/modules/fancyzones/editor/FancyZonesEditor/EditorWindow.cs: Evaluated as low risk
  • src/modules/fancyzones/UITests-FancyZonesEditor/Utils/IOTestHelper.cs: Evaluated as low risk
  • src/modules/fancyzones/UnitTests-FancyZonesEditor/DefaultLayoutsModelTests.cs: Evaluated as low risk
  • src/modules/fancyzones/UITests-FancyZonesEditor/TestConstants.cs: Evaluated as low risk
  • src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml.cs: Evaluated as low risk
  • src/modules/fancyzones/UITests-FancyZonesEditor/RunFancyZonesEditorTest.cs: Evaluated as low risk
  • src/modules/fancyzones/UITests-FancyZonesEditor/ApplyLayoutTests.cs: Evaluated as low risk
  • src/modules/fancyzones/UITests-FancyZonesEditor/DeleteLayoutTests.cs: Evaluated as low risk
  • src/modules/fancyzones/UITests-FancyZonesEditor/DefaultLayoutsTests.cs: Evaluated as low risk

src/modules/fancyzones/FancyZonesEditorCommon/Data/MonitorConfigurationTypeEnumExtensions.cs
private const string HorizontalJsonTag = "horizontal";
private const string VerticalJsonTag = "vertical";

public static string TypeToString(this MonitorConfigurationType value)
Copy link
Preview

Copilot AI Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a default case to the switch statement to handle unexpected values.

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
src/modules/fancyzones/FancyZonesEditorCommon/Data/MonitorConfigurationTypeEnumExtensions.cs
return HorizontalJsonTag;
}

public static MonitorConfigurationType TypeFromString(string value)
Copy link
Preview

Copilot AI Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a default case to the switch statement to handle unexpected values.

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@jamrobot jamrobot requested a review from Copilot February 24, 2025 09:41
Copilot
Copilot AI reviewed Feb 24, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 22 out of 37 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml: Language not supported
  • src/modules/fancyzones/FancyZonesEditorCommon/Data/Constants.cs: Evaluated as low risk
  • src/modules/fancyzones/editor/FancyZonesEditor/Converters/LayoutTypeCustomToVisibilityConverter.cs: Evaluated as low risk
  • src/modules/fancyzones/editor/FancyZonesEditor/Converters/LayoutModelTypeBlankToVisibilityConverter.cs: Evaluated as low risk
  • src/modules/fancyzones/editor/FancyZonesEditor/EditorWindow.cs: Evaluated as low risk
  • src/modules/fancyzones/editor/FancyZonesEditor/LayoutBackup.cs: Evaluated as low risk
  • src/modules/fancyzones/editor/FancyZonesEditor/Converters/LayoutTypeTemplateToVisibilityConverter.cs: Evaluated as low risk
  • src/modules/fancyzones/UITests-FancyZonesEditor/Utils/IOTestHelper.cs: Evaluated as low risk
  • src/modules/fancyzones/UnitTests-FancyZonesEditor/DefaultLayoutsModelTests.cs: Evaluated as low risk
  • src/modules/fancyzones/UITests-FancyZonesEditor/TestConstants.cs: Evaluated as low risk
  • src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml.cs: Evaluated as low risk
  • src/modules/fancyzones/UITests-FancyZonesEditor/RunFancyZonesEditorTest.cs: Evaluated as low risk
  • src/modules/fancyzones/UITests-FancyZonesEditor/ApplyLayoutTests.cs: Evaluated as low risk
  • src/modules/fancyzones/UITests-FancyZonesEditor/CreateLayoutTests.cs: Evaluated as low risk
  • src/modules/fancyzones/UITests-FancyZonesEditor/DefaultLayoutsTests.cs: Evaluated as low risk
@wang563681252
Copy link
Contributor

I will take this pr to new UI Test framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@jaimecbernardo jaimecbernardo Awaiting requested review from jaimecbernardo

@wang563681252 wang563681252 Awaiting requested review from wang563681252

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeraphimaZykova @wang563681252