-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Settings] Update GPO infobar icon, improve some pages and fix bugs #33703
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
Blocked because ...
|
src/settings-ui/Settings.UI/SettingsXAML/Views/AdvancedPaste.xaml
Outdated
Show resolved
Hide resolved
@jaimecbernardo , @crutkas |
Thank you @htcfreek. We're just waiting for some clarity on the exact PRs you've mentioned for this release, but indeed we'd like to include those PRs in this release if we can and only after that we'd get this PR in. |
Hi @htcfreek, We finally got those in 😅 Are you still willing to try and merge and propagate the changes to the missing pages? Thank you, in advance. |
@jaimecbernardo |
@jaimecbernardo Warning Build CI checks didn't run on this PR after merging main in. We have only my local debug build of settings project as verification. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Summary of the Pull Request
This PR updates the icon of the GPO managed info bars to a lock symbol.
Additionally this PR
fixes Behavior of CmdNotFound page when policy is configured.
improves order of info bars on PowerOcr page.
improves layout of the gpo infobar for adanced paste ai.
fixes a header icon on the advanced paste page.
improves layout of the standalone zoomit infobar.
fixes enabled state of image scale setting on zoomit page.
fixes the Awake page to use the correct enabled state if it is GPO configured.
PR Checklist
Detailed Description of the Pull Request / Additional comments
CmdNotFound module page
Old behavior
New behavior
PowerOCR page after change
Advanced page: fixed icon
Advanced page: AI info bar
Zoom It page after changes
Validation Steps Performed
Local test build.