Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] Update GPO infobar icon, improve some pages and fix bugs #33703

Open
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

htcfreek
Copy link
Collaborator

@htcfreek htcfreek commented Jul 7, 2024

Summary of the Pull Request

This PR updates the icon of the GPO managed info bars to a lock symbol.

Additionally this PR

  • fixes Behavior of CmdNotFound page when policy is configured.

  • improves order of info bars on PowerOcr page.

  • improves layout of the gpo infobar for adanced paste ai.

  • fixes a header icon on the advanced paste page.

  • improves layout of the standalone zoomit infobar.

  • fixes enabled state of image scale setting on zoomit page.

  • fixes the Awake page to use the correct enabled state if it is GPO configured.

PR Checklist

Detailed Description of the Pull Request / Additional comments

CmdNotFound module page

Old behavior
image

New behavior
image
image

PowerOCR page after change

image

Advanced page: fixed icon

image

Advanced page: AI info bar

image

Zoom It page after changes

image

Validation Steps Performed

Local test build.

@htcfreek htcfreek self-assigned this Jul 7, 2024
@htcfreek htcfreek added Product-Settings The standalone PowerToys Settings application Status-Blocked We can't make progress due to a dependency or issue labels Jul 7, 2024

This comment has been minimized.

@htcfreek htcfreek marked this pull request as ready for review August 24, 2024 17:28
@htcfreek
Copy link
Collaborator Author

Blocked because ...

@htcfreek htcfreek removed the Needs-Review This Pull Request awaits the review of a maintainer. label Oct 24, 2024
@htcfreek htcfreek removed the Status-Blocked We can't make progress due to a dependency or issue label Dec 7, 2024
@htcfreek
Copy link
Collaborator Author

htcfreek commented Dec 7, 2024

@jaimecbernardo , @crutkas
This PR is ready for review so far. If you like to merge #35880 and #35902 first, I have to update my PR to get it ready again.

@jaimecbernardo jaimecbernardo added the Needs-Review This Pull Request awaits the review of a maintainer. label Dec 9, 2024
@jaimecbernardo
Copy link
Collaborator

Thank you @htcfreek. We're just waiting for some clarity on the exact PRs you've mentioned for this release, but indeed we'd like to include those PRs in this release if we can and only after that we'd get this PR in.

@htcfreek htcfreek added the Status-Blocked We can't make progress due to a dependency or issue label Dec 9, 2024
@jaimecbernardo
Copy link
Collaborator

Hi @htcfreek, We finally got those in 😅 Are you still willing to try and merge and propagate the changes to the missing pages? Thank you, in advance.

@htcfreek
Copy link
Collaborator Author

@jaimecbernardo
Yes for sure. Later this day or at least this weekend.

@htcfreek htcfreek removed the Status-Blocked We can't make progress due to a dependency or issue label Jan 17, 2025
@htcfreek
Copy link
Collaborator Author

htcfreek commented Jan 17, 2025

@jaimecbernardo
PR is ready. 🔥🔥🔥🔥
Please read description for all changes included in the PR. (The PR also fixes a header icon on AdvPaste page on Win10.)

Warning

Build CI checks didn't run on this PR after merging main in. We have only my local debug build of settings project as verification.

@DHowett
Copy link
Member

DHowett commented Jan 17, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In for .88 Needs-Review This Pull Request awaits the review of a maintainer. Product-Settings The standalone PowerToys Settings application
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants