-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings in a window #37053
Closed
Closed
Settings in a window #37053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
niels9001
commented
Jan 24, 2025
- Settings are now in a window.
- Moved pages into a seperate pages folder
…ideos" command (working)
[UX] Fluent design
…users/ethanfang/youtube-ext
small changes to sample
Remove unused title bar
Use built in converters
Make SearchBar its own control
…edPlugin refactoring apps to dedicated project
Add ShellPage
Add ActionBar control
This never got hooked up in TRA. Now it is. And it actually does things smartly - it'll dismiss all the old extension instances, then re-populate all of them. Really helpful for testing extensions. You don't need to keep re-launching the palette, you can just reload and presto - we'll release the old package, let the new one deploy, then load the new one. It also revealed that we were updating the `.SearchText` from #234 on the UI thread. Oh no! Can't do that - that might be a x-proc call. Very bad. So that fixes this.
* Refactor package.h * Install on install * Fix install, remove package on uninstall and some auto-format * Start on enable() and close on PT close * Fix build * Change settings to toggle. If not installed, install on enable * Fix disable * Add infobar to PT Run page * Remove trailing sln project * remove reference * Remove comment
The meat of this PR is in `Microsoft.CmdPal.UI\CmdPal.Branding.props`. **TL;DR**: You can build cmdpal locally and have it not conflict with the selfhost build, allowing you to use the selfhost CmdPal while _also_ building and testing new features in a _separate_ package. This PR allows us to have different packages deployed by the build, depending on the "branding" of cmdpal which you're building. It's highly cribbed from the Terminal's concept of branding. This is all keyed off the `CommandPaletteBranding` property. This accepts different values: * `Release` / `Preview` / `Canary`: These are all the same currently. This is the "release" / "stable" branded version * `Dev` (or omitted, which is the default for local builds): Build the "dev" version of the package closes #297 Co-authored-by: Stefan Markovic <[email protected]>
The ListItems were having their icons manually initialized to `icon`, which was always passed as `string.Empty`. I suspect this is vestigial from PT Run - where the icon would be paseed in based on the theme. This prevented us from being able to fall back to the icon from the command, which is where we stuck the actual icon
Adds a setting to control if the `Details` pane is shown for apps on the main page or not. I'm defaulting this to off, because that pane doesn't add any value currently.
Changed results ordering to achieve the same relevance as in the current PT Run Indexer. Also adds fuzzy match support
Hey guess what, 24px is too tall! If you reserver 24 for the titlebar "drag area", it'll steal input from the top half of the back button, making it un-clickable. fun!
* [Workspaces] implement the move feature (microsoft#35480) * [Workspaces] Add move functionality * spell checker * [Workspaces] Modify Arranger to move apps without launch * moved ipc helper * removed callback * use LauncherStatus in WindowArranger * wait for launching next app * launch in a separate thread and protect by mutexes * update app version in advance * changed canceling launch * increased waiting time * Fix optional parameter load from json * changed arranger waiting time * additional waiting time for Outlook * added app id * ensure ids before launch * set id in editor * minor updates * [Workspaces] Move: Get the nearest window when moving a window * [Workspaces] convert optional boolean to enum to avoid json problems * Handle case when the new Application Property "moveIfExists" does not exist * Re-implementing app-window pairing for moving feature. * spell checker * XAML formatting * Fixing bug: IPC message not arriving * spell checker * Removing app-level-setting for move app. Also fixed compiler errors due styling. * Updating editor window layout * Re-implementing window positioning UI elements * XAML formatting * Code review findings * Code cleanup * Code cleanup * Code cleanup * code cleanup * Code cleanup * Code cleanup * fix Move attribute after launch and snapshot * Extend WindowArranger with PWA functionality to detect different PWA apps. PwaHelper moved to the common library * fix repeat counter in the editor * Code optimization * code cleanup, optimization * fix double-processing window --------- Co-authored-by: Seraphima <[email protected]> Co-authored-by: donlaci <[email protected]> * [KeyboardManager]Fix mapping shift to numpad (microsoft#35890) * Keyboard Manger fix numpad as shift Fixed shift not being released if a numpad key as shift. * Added comments * Fix typo * Fix the numpad unlocked key not working if the locked version is overridden by shift * Fix spelling check. * Revert the VK_CLEAR change. --------- Co-authored-by: Jaime Bernardo <[email protected]> * [Analyzers] Update .editorconfig with rules to relax IDE errors (microsoft#36095) * [Analyzers] Remove duplicate pascal case style from .editorconfig * [Analyzers] Configured severity for individual IDE and CA rules showing as errors in VS Set severity for IDE0005, IDE0008, IDE0016, IDE0018, IDE0019, IDE0021, IDE0022, IDE0023, IDE0025, IDE0027, IDE0028, IDE0029, IDE0031, IDE0032, IDE0034, IDE0036, IDE0039, IDE0042, IDE0044, IDE0045, IDE0046, IDE0047, IDE0057, IDE0051, IDE0052, IDE0054, IDE0055, IDE0056, IDE0057, IDE0059, IDE0060, IDE0061, IDE0063, IDE0071, IDE0073, IDE0074, IDE0075, IDE0077, IDE0078, IDE0083, IDE0090, IDE0100, IDE0130, IDE160, IDE180, IDE0200, IDE0240, IDE0250, IDE0251, IDE0260, IDE0270, IDE0290, IDE0300, IDE0301, IDE0305, IDE1005, IDE1006, CA1859, CA2022, CA2263 * [Analyzers] Fix mismatched analyzer descriptions * [Analyzers] Fix misspelling * Update .editorconfig Made the following style rules `silent` instead of `suggestion`: - Use explicit type instead of 'var' - Use expression body for ... - Use block-scoped namespace * [Analyzers] Set IDE0290 to silent * [Analyzers] Remove IDE1006 configuration from .editorconfig in favor of making exclusions for the few entries * [Analyzers][Indexer] Add IDE1006 suppressions * [Analyzers][Peek] Add IDE1006 suppression * [Analyzers][MWB] Add IDE1006 suppression. * [Analyzers][Plugins] Add IDE1006 suppression * [Analyzers][ImageResizer] Suppress IDE0073 to retain original copyright * [Analyzers] Remove IDE0073 severity change in .editorconfig --------- Co-authored-by: Ani <[email protected]> * [Workspaces] PWA follow-up (microsoft#36217) * [PTRun][Calculator]Allow scientific notation with lowercase 'e' (microsoft#36187) * [Workspaces] Add encoder parameter to bitmap.save() (microsoft#36228) * [Workspaces] Add encoder parameter to bitmap.save() * 1 more call fixed * Move repeated code to the csharp library * [Workspaces] Implement store of app window's size and position (microsoft#36086) * [Workspaces] Implement store of app window's size and position * Modifying the default values to -1. The program will use the original default values for the first run. * [ScreenRuler]Add setting to show the measurement in an extra unit (microsoft#35887) * display ruler: supporting millimeter and other units * Measurement Tool: UI Setting for an extra unit * Update images * spelling * spelling * suit code style * Fix for code review * remove weird file * rename field * [Deps]Update MSTest from 3.5.0 to 3.6.3 (microsoft#36115) * Update MSTest from 3.5.0 to 3.6.3 * Use STA attributes that are now part of MSTest * Adding Jerry to community.md (microsoft#36232) Update COMMUNITY.md * [Workspaces] Arranger: smart timer (microsoft#36096) * [Workspaces] Add move functionality * spell checker * [Workspaces] Modify Arranger to move apps without launch * moved ipc helper * removed callback * use LauncherStatus in WindowArranger * wait for launching next app * launch in a separate thread and protect by mutexes * update app version in advance * changed canceling launch * increased waiting time * Fix optional parameter load from json * changed arranger waiting time * additional waiting time for Outlook * added app id * ensure ids before launch * set id in editor * minor updates * [Workspaces] Move: Get the nearest window when moving a window * [Workspaces] convert optional boolean to enum to avoid json problems * Handle case when the new Application Property "moveIfExists" does not exist * Re-implementing app-window pairing for moving feature. * spell checker * XAML formatting * Fixing bug: IPC message not arriving * spell checker * Removing app-level-setting for move app. Also fixed compiler errors due styling. * Updating editor window layout * Re-implementing window positioning UI elements * XAML formatting * Code review findings * Code cleanup * Code cleanup * Code cleanup * code cleanup * Code cleanup * Code cleanup * [Workspaces] Arranger: Reset wait timer after each successful arrange action * fix merge error --------- Co-authored-by: Seraphima <[email protected]> Co-authored-by: donlaci <[email protected]> * Upgrade to check-spelling v0.0.24 (microsoft#36235) This upgrades to [v0.0.24](https://github.com/check-spelling/check-spelling/releases/tag/v0.0.24). A number of GitHub APIs are being turned off shortly, so you need to upgrade or various uncertain outcomes will occur. There's a new accessibility forbidden pattern: > Do not use `(click) here` links > For more information, see: > * https://www.w3.org/QA/Tips/noClickHere > * https://webaim.org/techniques/hypertext/link_text > * https://granicus.com/blog/why-click-here-links-are-bad/ > * https://heyoka.medium.com/dont-use-click-here-f32f445d1021 ```pl (?i)(?:>|\[)(?:(?:click |)here|link|(?:read |)more)(?:</|\]\() ``` There are some minor bugs that I'm aware of and which I've fixed since this release, but I don't expect to make another release this month. I've added a pair of patterns for includes and pragmas. My argument is that the **compiler** will _generally_ tell you if you've misspelled an include and the **linker** will _generally_ tell you if you misspell a lib. - There's a caveat here: If your include case-insensitively matches the referenced file (but doesn't properly match it), then unless you either use a case-sensitive file system (as opposed to case-preserving) or beg clang to warn, you won't notice when you make this specific mistake -- this matters in that a couple of Windows headers (e.g. Unknwn.h) have particular case and repositories don't tend to consistently/properly write them. * Adjust to community.md, shifting jerry's github user name (microsoft#36242) Update COMMUNITY.md * [AOT compatible] Resolve AOT Build Error in Peek.UI (microsoft#36194) * add partial for aot support * add Microsoft.NET.ILLink.Tasks to packages.props * format * Revert "format" This reverts commit 742d5e2. * add Microsoft.NET.ILLink.Tasks to notice.md * add auto reference * update script to remove the 'Auto-reference line' --------- Co-authored-by: Jaime Bernardo <[email protected]> * Awake Updates - `TILLSON_11272024` (microsoft#36049) * Update with bug fixes for tray icon and support for parent process * Process information enum * Update the docs * Fix spelling * Make sure that PID is used in PT config flow * Logic for checks based on microsoft#34148 * Update with link to PR * Fixes microsoft#34717 * Small cleanup * Proper task segmentation in a function * Cleanup the code * Fix synchronization context issue * Update planning doc * Test disabling caching to see if that manages to pass CI * Cleanup to make sure that we're logging things properly. * Update ci.yml * Disable cache to pass CI * Retry logic * Cleanup * Code cleanup * Fixes microsoft#35848 * Update notes and codename * After third attempt, log error instead of throwing exception * More cleanup to avoid double execution * Add expected word * Safeguards for bad values for timed keep-awake * More updates to make sure I am using uint * Update error message * Update packages * Fix notice and revert CsWinRT upgrade * Codename update * Update expect.txt * Update the struct * Ensuring we're properly awaiting tray initialization * Update to make sure tray reflects the bound process * Cleanup, proper JSON serialization for logs. * Not needed. * Add command validation logic * Moving the initialization logic earlier * Make sure we show the display state in the tooltip * Update tray string * Update src/modules/awake/Awake/Core/Manager.cs Co-authored-by: Jaime Bernardo <[email protected]> * Update src/modules/awake/Awake/Core/Manager.cs Co-authored-by: Jaime Bernardo <[email protected]> * Update src/modules/awake/Awake/Core/Manager.cs Co-authored-by: Jaime Bernardo <[email protected]> * Update src/modules/awake/Awake/Core/Manager.cs Co-authored-by: Jaime Bernardo <[email protected]> * Update logic for icon resets * Update doc * Simplify function for setting mode shell icon * Issues should be properly linked * Minor cleanup * Update timed behavior --------- Co-authored-by: Jaime Bernardo <[email protected]> Co-authored-by: Clint Rutkas <[email protected]> * [Workspaces] detecting right app version (microsoft#36100) * [Workspaces] Add move functionality * spell checker * [Workspaces] Modify Arranger to move apps without launch * moved ipc helper * removed callback * use LauncherStatus in WindowArranger * wait for launching next app * launch in a separate thread and protect by mutexes * update app version in advance * changed canceling launch * increased waiting time * Fix optional parameter load from json * changed arranger waiting time * additional waiting time for Outlook * added app id * ensure ids before launch * set id in editor * minor updates * [Workspaces] Move: Get the nearest window when moving a window * [Workspaces] convert optional boolean to enum to avoid json problems * Handle case when the new Application Property "moveIfExists" does not exist * Re-implementing app-window pairing for moving feature. * spell checker * XAML formatting * Fixing bug: IPC message not arriving * spell checker * Removing app-level-setting for move app. Also fixed compiler errors due styling. * Updating editor window layout * Re-implementing window positioning UI elements * XAML formatting * Code review findings * Code cleanup * Code cleanup * Code cleanup * code cleanup * Code cleanup * Code cleanup * [Workspaces] fix detection of specific version of apps --------- Co-authored-by: Seraphima <[email protected]> Co-authored-by: donlaci <[email protected]> * Move the XamlStyler config to src/ (microsoft#36202) my never ending goal to minimize files in the root dir * [AdvancedPaste]Add Semantic Kernel opt-in to allow chaining of paste actions (microsoft#35902) * [AdvancedPaste] Semantic Kernel support * Changed log-line with potentially sensitive info * Spellcheck issues * Various improvements for Semantic Kernel * Spellcheck issue * Refactored Clipboard routines * Added integration tests for KernelService * Extra telemetry for AdvancedPaste * Added 'Hotkey' suffix to AdvancedPaste_Settings telemetry event * Added IsSavedQuery * Added KernelQueryCache * Refactoring * Added KernelQueryCache to BugReportTool delete list * Added opt-n for Semantic Kernel * Fixed bug with KernelQueryCache * Ability to view last AI chat message on error * Improved kernel query cache * Used System.IO.Abstractions and improved tests * Fixed under-count of token usage * Used Semantic Kernel icon * Cleanup * Add missing EndProject line * Fix dependency version conflicts * Fix NOTICE.md * Correct place of SemanticKernel in NOTICE.md * Unlinked CustomPreview toggle from AI * Added Microsoft.Bcl.AsyncInterfaces dependency to AdvancedPaste * Fixed NOTICE.md order * Moved Custom Preview to behaviour section * Made Image to Text raise error on empty output * Added AIServiceBatchIntegrationTests * Updated AIServiceBatchIntegrationTests * Added prompt moderation * Moved GPO Infobar to better location * [Launcher]Port from WPF-UI to .NET 9 WPF (microsoft#36215) * Initial implementation * Fix fluent style * Fix no endline * Update expect.txt * Fix formatting * Fix light theme looking bad on Windows 10 * fix formatting * test change * Now really fixed W10 * Add a comment * Fix typos * Fix spellcheck errors * Fix spellcheck pattern for websites * Change patterns for spellcheck in the right file * Fix XAML styling * Fix contrast colors on W11 * Fix formatting * Removed emty line * Fix formatting * Added comment to fluentHC file * fix comment * Fix Windows10 again. Adress feedback. * W11 fix chaning from high contrast to normal not having correct background * W10 Fix high contrast not working after switching from light/dark moed * Address feedback * Fix formatting * Second W11 fix chaning from high contrast to normal not having correct background * [UX]Updating New+ and Settings icons (microsoft#36290) * Updated icons * Updating more icons and icos * [Settings][Dashboard] Accessibility fixes (microsoft#36280) * make narrator announce buttons/toggles * add toggles module name * [ci]Sign OpenAI dll that's not signed (microsoft#36299) * Update CODEOWNERS to include gordon, jerry and kayla (microsoft#36308) * Update CODEOWNERS * Update names.txt * Making the powertoys-code-owners team code owners (microsoft#36310) * Update CODEOWNERS * Update names.txt * Update CODEOWNERS * [FZEditor]Fix Create new layout dialog radio buttons IsChecked values (microsoft#36320) * 0.87 changelog (microsoft#36335) * 0.87 changelog * Fix spellcheck * Update README.md Co-authored-by: Heiko <[email protected]> --------- Co-authored-by: Heiko <[email protected]> * [PTRun]Fix WPF transparent border issue on Windows 10 (microsoft#36392) * Added border on W10 * Added a comment --------- Co-authored-by: Davide Giacometti <[email protected]> * [PTRun]Fix .NET 9 crash in OneNote (microsoft#36417) * Fix crash in OneNote Run * added better comment * [AdvancedPaste]Fix NullReferenceException on Dispose (microsoft#36428) [AdvancedPaste] Fixed NullReferenceException on Dispose * [Fuzz] Add fuzz testing for AdvancedPaste and new pipeline for onboarding OneFuzz (microsoft#36329) * add fuzz * install .net8 * add spelling check * refine the pipeline * add readme and update the test code * fix spelling error * change to weekly run * Add New CI Pipeline for Latest WindowsAppSDK (microsoft#36282) This PR introduces the following changes to the CI pipeline and version management: Pipeline Enhancements: 1. Added a new script UpdateVersions.ps1 to automate the update of Microsoft.WindowsAppSDK versions across various project files. 2. Introduced a new pipeline configuration ci-using-the-latest-winappsdk.yml to build using the latest Microsoft.WindowsAppSDK. 3. Updated existing pipeline configurations to support the new useLatestWinAppSDK parameter. Pipeline Configuration Updates: 1. Updated job-build-project.yml to handle the useLatestWinAppSDK parameter and adjust the RestoreAdditionalProjectSourcesArg accordingly. 2. Added a new template steps-update-winappsdk-and-restore-nuget.yml for updating and restoring NuGet packages with the latest Microsoft.WindowsAppSDK. 3. Added WinAPPSDK version selection, the pipeline can be manually triggered to use the specified version. --------- Signed-off-by: Shawn Yuan <[email protected]> Co-authored-by: Clint Rutkas <[email protected]> * [AOT compatible] Make HostsUILib become AOT compatible (microsoft#36136) * Remove AOT configuration * Refer to AOT compatibility props --------- Co-authored-by: Yu Leng (from Dev Box) <[email protected]> * [AOT compatible] Clean up some AOT build issue in FilePreviewCommon and MarkdownPreviewHandler (microsoft#36207) * Use AppContext.BaseDirectory to replace assembly.GetExeAseembly.Location. Fix json serilizer aot issue. * clean up some AOT build issue * Update src/modules/previewpane/MarkdownPreviewHandler/MarkdownPreviewHandlerControl.cs Co-authored-by: Jeremy Sinclair <[email protected]> * Update src/common/FilePreviewCommon/Formatters/JsonFormatter.cs Co-authored-by: Jeremy Sinclair <[email protected]> --------- Co-authored-by: Yu Leng (from Dev Box) <[email protected]> Co-authored-by: Jeremy Sinclair <[email protected]> * Add new pipeline using the latest webview2 from Edge Canary (microsoft#36317) * using the latest webview2 for testing --------- Signed-off-by: Shawn Yuan <[email protected]> Co-authored-by: Clint Rutkas <[email protected]> * [Bug fix] Making the OpenAI key configuration page scrollable. (microsoft#36359) * Fixed microsoft#34470 --------- Signed-off-by: Shawn Yuan <[email protected]> * [Bug fix] Add a format validation step before format conversion. (microsoft#36404) This PR aims to fix the bug microsoft#35225 by introducing a new method IsJson to determine if a given text is in JSON format. The IsJson method is then utilized in the ToJsonFromXmlOrCsvAsync method to optimize the processing logic. If the text is already in JSON format, it is returned directly without further conversion from XML or CSV. Co-authored-by: Heiko <[email protected]> --------- Signed-off-by: Shawn Yuan <[email protected]> Co-authored-by: Heiko <[email protected]> * Add more STCA team members (microsoft#36438) * Add more STCA team members * Include more spelling check errors * Remove non-alpha in dictionary * Add Zhaopeng Wang * Fix spell checking error * Remove "prerelease: true" (microsoft#36484) * Remove "prerelease: true" The Microsoft.WinGet.DSC module is GA so prerelease: true is no longer needed. * Update expect.txt fixing spellcheck warning --------- Co-authored-by: Clint Rutkas <[email protected]> * [Docs]Update README for 0.87.1 release (microsoft#36534) * [CI] Enhance build Pipeline Reliability with Retry Logic and Improved Error Messaging (microsoft#36529) * update pipeline with retry * remove tests * Add team member (microsoft#36590) * [New+]Don't override New actions from Explorer on Windows 10 (microsoft#36467) * [New+]Don't override New actions from Explorer * Update src/modules/NewPlus/NewShellExtensionContextMenu.win10/shell_context_menu_win10.cpp * Update src/modules/NewPlus/NewShellExtensionContextMenu.win10/shell_context_menu_win10.cpp * Add pattern for learn.microsoft links * Also only Query for context menu * [PTRun][Calculator]Handle hexadecimal numbers to not return divide by 0 error (microsoft#36390) * add '0x' handling for divide by 0 scenarios * fix comment on division by 0 check --------- Co-authored-by: Connor Plante <[email protected]> * [TextExtractor]Minor UI/Accessibility fixes in the overlay UI (microsoft#36356) minor UI and accessibility fixes * [PTRun][Calculator]Update mages to v3.0.0 and support for `randi(n)` (microsoft#36560) * update to mages 3.0.0 * allow randi() in calculator plugin * fix tests and input validation * fix spell check * [QuickAccent]Added ć for Slovenian (microsoft#36336) (microsoft#36338) * Fix snapping Workspaces Editor to Fancy Zones (microsoft#36463) * Remove Workspaces Editor from Fancy Zone's excluded app list * removed unused string --------- Co-authored-by: Seraphima <[email protected]> * [PTRun]Fix drag on .NET 9 WPF (microsoft#36635) * [CQ]Continued to move stuff out of root - Solution.props (microsoft#36244) * [QuickAccent]Add Proto-Indo-European (microsoft#36408) * Add ḱ to PowerAccent for Proto-Indo-European * Fix Spelling Check * Add more letters to PIE * Order PIE after PI --------- Co-authored-by: Hao Liu (from Dev Box) <[email protected]> Co-authored-by: Jaime Bernardo <[email protected]> * [PTRun]Add context buttons for VSCodeWorkspaces plugin (microsoft#36517) * [Settings][QuickAccent]Change 'character set' to plural form (microsoft#36565) * [PTRun][Calculator]Fix unit tests on non-english systems (microsoft#36569) * fix tests * update comment * [PTRun][Calc]Improve handling of non-base 10 numbers (microsoft#36700) * [Settings][PTRun]Show plugin version and website (microsoft#36580) * [Monaco]Add support for .resx and .resw preview support. (microsoft#36499) Added support for .resx and .resw preview support. These files are XML based files so I added the file extensions as part of the registerAdditionalLanguage("xmlExt"...) function. * [Settings] Add Workspaces' workspaces.json file to backup/restore list (microsoft#36714) * [Localization] Fix loc pipeline to send downloaded localized files to TDBuild upon retry after failure (microsoft#36766) * [AdvancedPaste]Fixed issues with Screen Reader integration (microsoft#36778) * Remove Advent calendar from README (microsoft#36777) * Remove Advent calendar from README * Update hero image * Delete doc/images/overview/PT_holiday_hero_image.png * [AdvancedPaste]Add all BitmapDecoder supported image filetypes to ImageToText (microsoft#35600) Adds support to ImageToText for all image filetypes supported by BitmapDecoder. * [AOT]Clean up some AOT build issues in PowerAccent.Core (microsoft#36264) * init * Use AotCompatibility instead * Replace typeof(Lanaguge) with GetValues<Language> * Create new folder to place source generation context file. --------- Co-authored-by: Yu Leng (from Dev Box) <[email protected]> * [WinUI3]Fix Windows 10 title bar borders (microsoft#36429) * Fix borders for windows in the Settings UI * Fix HOSTS window * Fix Advanced Paste * Fix Environment Variables * Fix File Locksmith * Fix Peek, with a caveat * Fix Registry Preview * Remove unused imports * Clean up imports in OobeShellPage * Move OSVersionHelper from Common.UI up into ManagedCommon * [QuickAccent]Fix unstable language loading (microsoft#36721) * [Peek]Bring into foreground if previously minimized (microsoft#36506) Added Activate() to bring Peek.UI window into focus upon Toggle. This allows the UI to be presented even if it was previously minimized. * Update Run docs README (microsoft#36857) * Update Run docs README * Remove System dupe * [Monaco]Make minimap toggleable (microsoft#33742) * [Monaco]Fix Json format preview setting (microsoft#36867) * [KBM]Added option for exact match shortcut (microsoft#36000) * Added option for exact match shortcut * Fix spell-check * [Deps][Security]Update .NET Packages from 9.0.0 to 9.0.1 (microsoft#36879) * [Deps] Update NuGet packages to version 9.0.1 Updated several NuGet packages from version 9.0.0 to 9.0.1, including: - Microsoft.Data.Sqlite - Microsoft.Bcl.AsyncInterfaces - Microsoft.Extensions.DependencyInjection - Microsoft.Extensions.Logging - Microsoft.Extensions.Logging.Abstractions - Microsoft.Extensions.Hosting - Microsoft.Extensions.Hosting.WindowsServices - Microsoft.Win32.SystemEvents - Microsoft.Windows.Compatibility - System.CodeDom - System.ComponentModel.Composition - System.Configuration.ConfigurationManager - System.Data.OleDb - System.Diagnostics.EventLog - System.Diagnostics.PerformanceCounter - System.Drawing.Common - System.Management - System.Runtime.Caching - System.ServiceProcess.ServiceController - System.Text.Encoding.CodePages - System.Text.Json * [Deps] Update NOTICE.md * Fix bad merge * [check-spelling] Update metadata Update for https://github.com/zadjii-msft/PowerToys/actions/runs/12790673218/attempts/1 Accepted in #330 (comment) Signed-off-by: check-spelling-bot <[email protected]> on-behalf-of: @check-spelling <[email protected]> --------- Signed-off-by: Shawn Yuan <[email protected]> Signed-off-by: check-spelling-bot <[email protected]> Co-authored-by: Laszlo Nemeth <[email protected]> Co-authored-by: Seraphima <[email protected]> Co-authored-by: donlaci <[email protected]> Co-authored-by: Ionuț Manța <[email protected]> Co-authored-by: Jaime Bernardo <[email protected]> Co-authored-by: Jeremy Sinclair <[email protected]> Co-authored-by: Ani <[email protected]> Co-authored-by: PesBandi <[email protected]> Co-authored-by: Wenjian Chern <[email protected]> Co-authored-by: Youssef Victor <[email protected]> Co-authored-by: Clint Rutkas <[email protected]> Co-authored-by: Josh Soref <[email protected]> Co-authored-by: leileizhang <[email protected]> Co-authored-by: Den Delimarsky 🔐 <[email protected]> Co-authored-by: Niels Laute <[email protected]> Co-authored-by: Davide Giacometti <[email protected]> Co-authored-by: Heiko <[email protected]> Co-authored-by: Shuai Yuan <[email protected]> Co-authored-by: moooyo <[email protected]> Co-authored-by: Yu Leng (from Dev Box) <[email protected]> Co-authored-by: Jerry Xu <[email protected]> Co-authored-by: Demitrius Nelon <[email protected]> Co-authored-by: Kai Tao <[email protected]> Co-authored-by: Connor Plante <[email protected]> Co-authored-by: Connor Plante <[email protected]> Co-authored-by: Domen Soklič <[email protected]> Co-authored-by: Hao Liu <[email protected]> Co-authored-by: Hao Liu (from Dev Box) <[email protected]> Co-authored-by: immi <[email protected]> Co-authored-by: Asif Islam <[email protected]> Co-authored-by: Kayla Cinnamon <[email protected]> Co-authored-by: Dave Rayment <[email protected]> Co-authored-by: Neil McAlister <[email protected]> Co-authored-by: Stefan Markovic <[email protected]>
When we changed icons to be a pair of IconData in an IconInfo, I forgot this type check. Oops. Now it works again. Originally in #265 Regressed in #286 (targets #308, which targets #299) `IconData` and `IconInfo` are unfortunately, not trivially marshallable into the host process. This creates a collection of cases where an app can crash and take the host down, because we'll try to inquire something about the icon. It broke reloading when an extension crashed. It broke backing out of a crashed extension. Previously: #218 Closes #235
This PR: - moves the tag logic from the ListDetailsPage to the Tag control, so it can be re-used at other places as well. - provides a default style (that can be easily be extended / overriden) that is theme aware. - adds a BorderBrush property to the Tag viewmodel so that can be set as well Default dark:  Default light:  Pokedex: 
I'm smarter than that, really. As described in #302. You can't write into `WindowsApps`, where actual packages are installed. Instead, you need to use the local app data path. This replicates logic that we've got in the Terminal, for getting the right LocalAppData path, without using Windows.Storage. Original code looks like: ```c++ _TIL_INLINEPREFIX bool IsPackaged() { static const auto isPackaged = []() { UINT32 bufferLength = 0; const auto hr = GetCurrentPackageId(&bufferLength, nullptr); return hr != APPMODEL_ERROR_NO_PACKAGE; }(); return isPackaged; } std::filesystem::path GetBaseSettingsPath() { static auto baseSettingsPath = []() { /* some portable mode code we don't need */ wil::unique_cotaskmem_string localAppDataFolder; // KF_FLAG_FORCE_APP_DATA_REDIRECTION, when engaged, causes SHGet... to return // the new AppModel paths (Packages/xxx/RoamingState, etc.) for standard path requests. // Using this flag allows us to avoid Windows.Storage.ApplicationData completely. THROW_IF_FAILED(SHGetKnownFolderPath(FOLDERID_LocalAppData, KF_FLAG_FORCE_APP_DATA_REDIRECTION, nullptr, &localAppDataFolder)); std::filesystem::path parentDirectoryForSettingsFile{ localAppDataFolder.get() }; if (!IsPackaged()) { parentDirectoryForSettingsFile /= UnpackagedSettingsFolderName; } // Create the directory if it doesn't exist std::filesystem::create_directories(parentDirectoryForSettingsFile); return parentDirectoryForSettingsFile; }(); return baseSettingsPath; } ``` I stuck this in a `Helpers.Utilities` class, because we will not be the only ones hitting this. Closes #302
Most of my notes are in #322. This one was a journey. The app was doing something re-entrant when we changed the selected item. It had nothing to do with `ScrollIntoView` (though, not calling that would stop the crash). Seems like that `ItemsList_SelectionChanged` -> `UpdateSelectedItemCommand` -> `WeakReferenceMessenger.Default.Send<ShowDetailsMessage>`, all on the UI thread, seemed to really make XAML mad. And a combination of hopping to the background thread, and debouncing the `ShowDetails` call, seemed to fix it. Tags made it worse - presumbaly it made the XAML layout pass take longer, which widened the window for the app to think it was re-entrant Closes #322
This is like, the 99% ues case, so it would be nice if this was easy. I'm also experimenting with making fewer instances of Tag objects, to see if that helps things. Not yet, but we'll see
This PR is a ton of _plumbing_. UX-wise, this is very rough. What's more important in this PR is the broad wiring this does, to connect individual pages with the `IExtension` that's hosting them. `CommandPaletteHost` is the important new class that we're introducing. This is the class that implements the `IExtensionHost` interface, and is the one by which extensions can use to log messages back to the host. There's both: * A singleton instance of the `CommandPaletteHost`, which represents all global state, * per-extension instances of the `CommandPaletteHost`, which allows us to know which extension a message came from. When we fetch a command provider, we'll create a new `CommandPaletteHost` for that extension, and connect the extension to that instance. * Log messages from an extension go to the global list of messages, so those go to the global instance's list of `LogMessageViewModel`s * When an extension writes status messages, we'll add the messages to _that extension's_ `CommandPaletteHost`. * The `PageContext` is aware of the `CommandPaletteHost`, so it can now retrieve information about the hosting extension for that page. Since all pages for an extension share a single `CommandPaletteHost`, status messages can be shown across all the pages in that extension's context, then hidden when the user leaves that context. This also does part of #253, because now we have a `TopLevelCommandWrapper` AND a `TopLevelCommandItemWrapper`, separately. That lets us store the `CommandPaletteHost` in the `TopLevelCommandWrapper`, which we need so that when we activate a top-level command, we can fetch the extension host out of it and give it to the pages that follow. Also included is the "single builtin command provider" which is also in #264, because it's kinda insane to have things like "Quit", "Reload extension", "View log", things which are all _core pieces of the palette itself_, each need a separate provider. That's insane. I didn't add support for: * Extensions to hide messages once they're shown * I dunno if `PropChanged`'ing a status message works * I didn't add support for progress bars yet, because it's NOT TRIVIAL to replace the icon of an InfoBar with a progress wheel. What the heck WinUI 😠 * Again, this is Programmer Xaml - we'll need real designers to come around and clean this up --------- Co-authored-by: Mike Griese <[email protected]>
And the placeholder text too. This one's mildly confusing, because we don't want the View and the Model fighting over the same exact property. Basically I just have the view be able to call the SearchText setter, and the model's PropChanged is listened to by the View. They shouldn't fight too much then. Closes #163 Closes #112
_targets #281_ Adds tags onto top-level items that have an alias assigned to them  Closes #312
The fallback command was still showing up on empty query because we weren't explicitly setting the underlying command name to the empty string when it is empty. This is what it looked like in the root view:  This is a really small PR that just fixes that issue.
Closes #327 Pretty straightforward this. Just restore the window if we're minimized. Co-authored-by: Mike Griese <[email protected]>
* [Workspaces] implement the move feature (microsoft#35480) * [Workspaces] Add move functionality * spell checker * [Workspaces] Modify Arranger to move apps without launch * moved ipc helper * removed callback * use LauncherStatus in WindowArranger * wait for launching next app * launch in a separate thread and protect by mutexes * update app version in advance * changed canceling launch * increased waiting time * Fix optional parameter load from json * changed arranger waiting time * additional waiting time for Outlook * added app id * ensure ids before launch * set id in editor * minor updates * [Workspaces] Move: Get the nearest window when moving a window * [Workspaces] convert optional boolean to enum to avoid json problems * Handle case when the new Application Property "moveIfExists" does not exist * Re-implementing app-window pairing for moving feature. * spell checker * XAML formatting * Fixing bug: IPC message not arriving * spell checker * Removing app-level-setting for move app. Also fixed compiler errors due styling. * Updating editor window layout * Re-implementing window positioning UI elements * XAML formatting * Code review findings * Code cleanup * Code cleanup * Code cleanup * code cleanup * Code cleanup * Code cleanup * fix Move attribute after launch and snapshot * Extend WindowArranger with PWA functionality to detect different PWA apps. PwaHelper moved to the common library * fix repeat counter in the editor * Code optimization * code cleanup, optimization * fix double-processing window --------- Co-authored-by: Seraphima <[email protected]> Co-authored-by: donlaci <[email protected]> * [KeyboardManager]Fix mapping shift to numpad (microsoft#35890) * Keyboard Manger fix numpad as shift Fixed shift not being released if a numpad key as shift. * Added comments * Fix typo * Fix the numpad unlocked key not working if the locked version is overridden by shift * Fix spelling check. * Revert the VK_CLEAR change. --------- Co-authored-by: Jaime Bernardo <[email protected]> * [Analyzers] Update .editorconfig with rules to relax IDE errors (microsoft#36095) * [Analyzers] Remove duplicate pascal case style from .editorconfig * [Analyzers] Configured severity for individual IDE and CA rules showing as errors in VS Set severity for IDE0005, IDE0008, IDE0016, IDE0018, IDE0019, IDE0021, IDE0022, IDE0023, IDE0025, IDE0027, IDE0028, IDE0029, IDE0031, IDE0032, IDE0034, IDE0036, IDE0039, IDE0042, IDE0044, IDE0045, IDE0046, IDE0047, IDE0057, IDE0051, IDE0052, IDE0054, IDE0055, IDE0056, IDE0057, IDE0059, IDE0060, IDE0061, IDE0063, IDE0071, IDE0073, IDE0074, IDE0075, IDE0077, IDE0078, IDE0083, IDE0090, IDE0100, IDE0130, IDE160, IDE180, IDE0200, IDE0240, IDE0250, IDE0251, IDE0260, IDE0270, IDE0290, IDE0300, IDE0301, IDE0305, IDE1005, IDE1006, CA1859, CA2022, CA2263 * [Analyzers] Fix mismatched analyzer descriptions * [Analyzers] Fix misspelling * Update .editorconfig Made the following style rules `silent` instead of `suggestion`: - Use explicit type instead of 'var' - Use expression body for ... - Use block-scoped namespace * [Analyzers] Set IDE0290 to silent * [Analyzers] Remove IDE1006 configuration from .editorconfig in favor of making exclusions for the few entries * [Analyzers][Indexer] Add IDE1006 suppressions * [Analyzers][Peek] Add IDE1006 suppression * [Analyzers][MWB] Add IDE1006 suppression. * [Analyzers][Plugins] Add IDE1006 suppression * [Analyzers][ImageResizer] Suppress IDE0073 to retain original copyright * [Analyzers] Remove IDE0073 severity change in .editorconfig --------- Co-authored-by: Ani <[email protected]> * [Workspaces] PWA follow-up (microsoft#36217) * [PTRun][Calculator]Allow scientific notation with lowercase 'e' (microsoft#36187) * [Workspaces] Add encoder parameter to bitmap.save() (microsoft#36228) * [Workspaces] Add encoder parameter to bitmap.save() * 1 more call fixed * Move repeated code to the csharp library * [Workspaces] Implement store of app window's size and position (microsoft#36086) * [Workspaces] Implement store of app window's size and position * Modifying the default values to -1. The program will use the original default values for the first run. * [ScreenRuler]Add setting to show the measurement in an extra unit (microsoft#35887) * display ruler: supporting millimeter and other units * Measurement Tool: UI Setting for an extra unit * Update images * spelling * spelling * suit code style * Fix for code review * remove weird file * rename field * [Deps]Update MSTest from 3.5.0 to 3.6.3 (microsoft#36115) * Update MSTest from 3.5.0 to 3.6.3 * Use STA attributes that are now part of MSTest * Adding Jerry to community.md (microsoft#36232) Update COMMUNITY.md * [Workspaces] Arranger: smart timer (microsoft#36096) * [Workspaces] Add move functionality * spell checker * [Workspaces] Modify Arranger to move apps without launch * moved ipc helper * removed callback * use LauncherStatus in WindowArranger * wait for launching next app * launch in a separate thread and protect by mutexes * update app version in advance * changed canceling launch * increased waiting time * Fix optional parameter load from json * changed arranger waiting time * additional waiting time for Outlook * added app id * ensure ids before launch * set id in editor * minor updates * [Workspaces] Move: Get the nearest window when moving a window * [Workspaces] convert optional boolean to enum to avoid json problems * Handle case when the new Application Property "moveIfExists" does not exist * Re-implementing app-window pairing for moving feature. * spell checker * XAML formatting * Fixing bug: IPC message not arriving * spell checker * Removing app-level-setting for move app. Also fixed compiler errors due styling. * Updating editor window layout * Re-implementing window positioning UI elements * XAML formatting * Code review findings * Code cleanup * Code cleanup * Code cleanup * code cleanup * Code cleanup * Code cleanup * [Workspaces] Arranger: Reset wait timer after each successful arrange action * fix merge error --------- Co-authored-by: Seraphima <[email protected]> Co-authored-by: donlaci <[email protected]> * Upgrade to check-spelling v0.0.24 (microsoft#36235) This upgrades to [v0.0.24](https://github.com/check-spelling/check-spelling/releases/tag/v0.0.24). A number of GitHub APIs are being turned off shortly, so you need to upgrade or various uncertain outcomes will occur. There's a new accessibility forbidden pattern: > Do not use `(click) here` links > For more information, see: > * https://www.w3.org/QA/Tips/noClickHere > * https://webaim.org/techniques/hypertext/link_text > * https://granicus.com/blog/why-click-here-links-are-bad/ > * https://heyoka.medium.com/dont-use-click-here-f32f445d1021 ```pl (?i)(?:>|\[)(?:(?:click |)here|link|(?:read |)more)(?:</|\]\() ``` There are some minor bugs that I'm aware of and which I've fixed since this release, but I don't expect to make another release this month. I've added a pair of patterns for includes and pragmas. My argument is that the **compiler** will _generally_ tell you if you've misspelled an include and the **linker** will _generally_ tell you if you misspell a lib. - There's a caveat here: If your include case-insensitively matches the referenced file (but doesn't properly match it), then unless you either use a case-sensitive file system (as opposed to case-preserving) or beg clang to warn, you won't notice when you make this specific mistake -- this matters in that a couple of Windows headers (e.g. Unknwn.h) have particular case and repositories don't tend to consistently/properly write them. * Adjust to community.md, shifting jerry's github user name (microsoft#36242) Update COMMUNITY.md * [AOT compatible] Resolve AOT Build Error in Peek.UI (microsoft#36194) * add partial for aot support * add Microsoft.NET.ILLink.Tasks to packages.props * format * Revert "format" This reverts commit 742d5e2. * add Microsoft.NET.ILLink.Tasks to notice.md * add auto reference * update script to remove the 'Auto-reference line' --------- Co-authored-by: Jaime Bernardo <[email protected]> * Awake Updates - `TILLSON_11272024` (microsoft#36049) * Update with bug fixes for tray icon and support for parent process * Process information enum * Update the docs * Fix spelling * Make sure that PID is used in PT config flow * Logic for checks based on microsoft#34148 * Update with link to PR * Fixes microsoft#34717 * Small cleanup * Proper task segmentation in a function * Cleanup the code * Fix synchronization context issue * Update planning doc * Test disabling caching to see if that manages to pass CI * Cleanup to make sure that we're logging things properly. * Update ci.yml * Disable cache to pass CI * Retry logic * Cleanup * Code cleanup * Fixes microsoft#35848 * Update notes and codename * After third attempt, log error instead of throwing exception * More cleanup to avoid double execution * Add expected word * Safeguards for bad values for timed keep-awake * More updates to make sure I am using uint * Update error message * Update packages * Fix notice and revert CsWinRT upgrade * Codename update * Update expect.txt * Update the struct * Ensuring we're properly awaiting tray initialization * Update to make sure tray reflects the bound process * Cleanup, proper JSON serialization for logs. * Not needed. * Add command validation logic * Moving the initialization logic earlier * Make sure we show the display state in the tooltip * Update tray string * Update src/modules/awake/Awake/Core/Manager.cs Co-authored-by: Jaime Bernardo <[email protected]> * Update src/modules/awake/Awake/Core/Manager.cs Co-authored-by: Jaime Bernardo <[email protected]> * Update src/modules/awake/Awake/Core/Manager.cs Co-authored-by: Jaime Bernardo <[email protected]> * Update src/modules/awake/Awake/Core/Manager.cs Co-authored-by: Jaime Bernardo <[email protected]> * Update logic for icon resets * Update doc * Simplify function for setting mode shell icon * Issues should be properly linked * Minor cleanup * Update timed behavior --------- Co-authored-by: Jaime Bernardo <[email protected]> Co-authored-by: Clint Rutkas <[email protected]> * [Workspaces] detecting right app version (microsoft#36100) * [Workspaces] Add move functionality * spell checker * [Workspaces] Modify Arranger to move apps without launch * moved ipc helper * removed callback * use LauncherStatus in WindowArranger * wait for launching next app * launch in a separate thread and protect by mutexes * update app version in advance * changed canceling launch * increased waiting time * Fix optional parameter load from json * changed arranger waiting time * additional waiting time for Outlook * added app id * ensure ids before launch * set id in editor * minor updates * [Workspaces] Move: Get the nearest window when moving a window * [Workspaces] convert optional boolean to enum to avoid json problems * Handle case when the new Application Property "moveIfExists" does not exist * Re-implementing app-window pairing for moving feature. * spell checker * XAML formatting * Fixing bug: IPC message not arriving * spell checker * Removing app-level-setting for move app. Also fixed compiler errors due styling. * Updating editor window layout * Re-implementing window positioning UI elements * XAML formatting * Code review findings * Code cleanup * Code cleanup * Code cleanup * code cleanup * Code cleanup * Code cleanup * [Workspaces] fix detection of specific version of apps --------- Co-authored-by: Seraphima <[email protected]> Co-authored-by: donlaci <[email protected]> * Move the XamlStyler config to src/ (microsoft#36202) my never ending goal to minimize files in the root dir * [AdvancedPaste]Add Semantic Kernel opt-in to allow chaining of paste actions (microsoft#35902) * [AdvancedPaste] Semantic Kernel support * Changed log-line with potentially sensitive info * Spellcheck issues * Various improvements for Semantic Kernel * Spellcheck issue * Refactored Clipboard routines * Added integration tests for KernelService * Extra telemetry for AdvancedPaste * Added 'Hotkey' suffix to AdvancedPaste_Settings telemetry event * Added IsSavedQuery * Added KernelQueryCache * Refactoring * Added KernelQueryCache to BugReportTool delete list * Added opt-n for Semantic Kernel * Fixed bug with KernelQueryCache * Ability to view last AI chat message on error * Improved kernel query cache * Used System.IO.Abstractions and improved tests * Fixed under-count of token usage * Used Semantic Kernel icon * Cleanup * Add missing EndProject line * Fix dependency version conflicts * Fix NOTICE.md * Correct place of SemanticKernel in NOTICE.md * Unlinked CustomPreview toggle from AI * Added Microsoft.Bcl.AsyncInterfaces dependency to AdvancedPaste * Fixed NOTICE.md order * Moved Custom Preview to behaviour section * Made Image to Text raise error on empty output * Added AIServiceBatchIntegrationTests * Updated AIServiceBatchIntegrationTests * Added prompt moderation * Moved GPO Infobar to better location * [Launcher]Port from WPF-UI to .NET 9 WPF (microsoft#36215) * Initial implementation * Fix fluent style * Fix no endline * Update expect.txt * Fix formatting * Fix light theme looking bad on Windows 10 * fix formatting * test change * Now really fixed W10 * Add a comment * Fix typos * Fix spellcheck errors * Fix spellcheck pattern for websites * Change patterns for spellcheck in the right file * Fix XAML styling * Fix contrast colors on W11 * Fix formatting * Removed emty line * Fix formatting * Added comment to fluentHC file * fix comment * Fix Windows10 again. Adress feedback. * W11 fix chaning from high contrast to normal not having correct background * W10 Fix high contrast not working after switching from light/dark moed * Address feedback * Fix formatting * Second W11 fix chaning from high contrast to normal not having correct background * [UX]Updating New+ and Settings icons (microsoft#36290) * Updated icons * Updating more icons and icos * [Settings][Dashboard] Accessibility fixes (microsoft#36280) * make narrator announce buttons/toggles * add toggles module name * [ci]Sign OpenAI dll that's not signed (microsoft#36299) * Update CODEOWNERS to include gordon, jerry and kayla (microsoft#36308) * Update CODEOWNERS * Update names.txt * Making the powertoys-code-owners team code owners (microsoft#36310) * Update CODEOWNERS * Update names.txt * Update CODEOWNERS * [FZEditor]Fix Create new layout dialog radio buttons IsChecked values (microsoft#36320) * 0.87 changelog (microsoft#36335) * 0.87 changelog * Fix spellcheck * Update README.md Co-authored-by: Heiko <[email protected]> --------- Co-authored-by: Heiko <[email protected]> * [PTRun]Fix WPF transparent border issue on Windows 10 (microsoft#36392) * Added border on W10 * Added a comment --------- Co-authored-by: Davide Giacometti <[email protected]> * [PTRun]Fix .NET 9 crash in OneNote (microsoft#36417) * Fix crash in OneNote Run * added better comment * [AdvancedPaste]Fix NullReferenceException on Dispose (microsoft#36428) [AdvancedPaste] Fixed NullReferenceException on Dispose * [Fuzz] Add fuzz testing for AdvancedPaste and new pipeline for onboarding OneFuzz (microsoft#36329) * add fuzz * install .net8 * add spelling check * refine the pipeline * add readme and update the test code * fix spelling error * change to weekly run * Add New CI Pipeline for Latest WindowsAppSDK (microsoft#36282) This PR introduces the following changes to the CI pipeline and version management: Pipeline Enhancements: 1. Added a new script UpdateVersions.ps1 to automate the update of Microsoft.WindowsAppSDK versions across various project files. 2. Introduced a new pipeline configuration ci-using-the-latest-winappsdk.yml to build using the latest Microsoft.WindowsAppSDK. 3. Updated existing pipeline configurations to support the new useLatestWinAppSDK parameter. Pipeline Configuration Updates: 1. Updated job-build-project.yml to handle the useLatestWinAppSDK parameter and adjust the RestoreAdditionalProjectSourcesArg accordingly. 2. Added a new template steps-update-winappsdk-and-restore-nuget.yml for updating and restoring NuGet packages with the latest Microsoft.WindowsAppSDK. 3. Added WinAPPSDK version selection, the pipeline can be manually triggered to use the specified version. --------- Signed-off-by: Shawn Yuan <[email protected]> Co-authored-by: Clint Rutkas <[email protected]> * [AOT compatible] Make HostsUILib become AOT compatible (microsoft#36136) * Remove AOT configuration * Refer to AOT compatibility props --------- Co-authored-by: Yu Leng (from Dev Box) <[email protected]> * [AOT compatible] Clean up some AOT build issue in FilePreviewCommon and MarkdownPreviewHandler (microsoft#36207) * Use AppContext.BaseDirectory to replace assembly.GetExeAseembly.Location. Fix json serilizer aot issue. * clean up some AOT build issue * Update src/modules/previewpane/MarkdownPreviewHandler/MarkdownPreviewHandlerControl.cs Co-authored-by: Jeremy Sinclair <[email protected]> * Update src/common/FilePreviewCommon/Formatters/JsonFormatter.cs Co-authored-by: Jeremy Sinclair <[email protected]> --------- Co-authored-by: Yu Leng (from Dev Box) <[email protected]> Co-authored-by: Jeremy Sinclair <[email protected]> * Add new pipeline using the latest webview2 from Edge Canary (microsoft#36317) * using the latest webview2 for testing --------- Signed-off-by: Shawn Yuan <[email protected]> Co-authored-by: Clint Rutkas <[email protected]> * [Bug fix] Making the OpenAI key configuration page scrollable. (microsoft#36359) * Fixed microsoft#34470 --------- Signed-off-by: Shawn Yuan <[email protected]> * [Bug fix] Add a format validation step before format conversion. (microsoft#36404) This PR aims to fix the bug microsoft#35225 by introducing a new method IsJson to determine if a given text is in JSON format. The IsJson method is then utilized in the ToJsonFromXmlOrCsvAsync method to optimize the processing logic. If the text is already in JSON format, it is returned directly without further conversion from XML or CSV. Co-authored-by: Heiko <[email protected]> --------- Signed-off-by: Shawn Yuan <[email protected]> Co-authored-by: Heiko <[email protected]> * Add more STCA team members (microsoft#36438) * Add more STCA team members * Include more spelling check errors * Remove non-alpha in dictionary * Add Zhaopeng Wang * Fix spell checking error * Remove "prerelease: true" (microsoft#36484) * Remove "prerelease: true" The Microsoft.WinGet.DSC module is GA so prerelease: true is no longer needed. * Update expect.txt fixing spellcheck warning --------- Co-authored-by: Clint Rutkas <[email protected]> * [Docs]Update README for 0.87.1 release (microsoft#36534) * [CI] Enhance build Pipeline Reliability with Retry Logic and Improved Error Messaging (microsoft#36529) * update pipeline with retry * remove tests * Add team member (microsoft#36590) * [New+]Don't override New actions from Explorer on Windows 10 (microsoft#36467) * [New+]Don't override New actions from Explorer * Update src/modules/NewPlus/NewShellExtensionContextMenu.win10/shell_context_menu_win10.cpp * Update src/modules/NewPlus/NewShellExtensionContextMenu.win10/shell_context_menu_win10.cpp * Add pattern for learn.microsoft links * Also only Query for context menu * [PTRun][Calculator]Handle hexadecimal numbers to not return divide by 0 error (microsoft#36390) * add '0x' handling for divide by 0 scenarios * fix comment on division by 0 check --------- Co-authored-by: Connor Plante <[email protected]> * [TextExtractor]Minor UI/Accessibility fixes in the overlay UI (microsoft#36356) minor UI and accessibility fixes * [PTRun][Calculator]Update mages to v3.0.0 and support for `randi(n)` (microsoft#36560) * update to mages 3.0.0 * allow randi() in calculator plugin * fix tests and input validation * fix spell check * [QuickAccent]Added ć for Slovenian (microsoft#36336) (microsoft#36338) * Fix snapping Workspaces Editor to Fancy Zones (microsoft#36463) * Remove Workspaces Editor from Fancy Zone's excluded app list * removed unused string --------- Co-authored-by: Seraphima <[email protected]> * [PTRun]Fix drag on .NET 9 WPF (microsoft#36635) * [CQ]Continued to move stuff out of root - Solution.props (microsoft#36244) * [QuickAccent]Add Proto-Indo-European (microsoft#36408) * Add ḱ to PowerAccent for Proto-Indo-European * Fix Spelling Check * Add more letters to PIE * Order PIE after PI --------- Co-authored-by: Hao Liu (from Dev Box) <[email protected]> Co-authored-by: Jaime Bernardo <[email protected]> * [PTRun]Add context buttons for VSCodeWorkspaces plugin (microsoft#36517) * [Settings][QuickAccent]Change 'character set' to plural form (microsoft#36565) * [PTRun][Calculator]Fix unit tests on non-english systems (microsoft#36569) * fix tests * update comment * [PTRun][Calc]Improve handling of non-base 10 numbers (microsoft#36700) * [Settings][PTRun]Show plugin version and website (microsoft#36580) * [Monaco]Add support for .resx and .resw preview support. (microsoft#36499) Added support for .resx and .resw preview support. These files are XML based files so I added the file extensions as part of the registerAdditionalLanguage("xmlExt"...) function. * [Settings] Add Workspaces' workspaces.json file to backup/restore list (microsoft#36714) * [Localization] Fix loc pipeline to send downloaded localized files to TDBuild upon retry after failure (microsoft#36766) * [AdvancedPaste]Fixed issues with Screen Reader integration (microsoft#36778) * Remove Advent calendar from README (microsoft#36777) * Remove Advent calendar from README * Update hero image * Delete doc/images/overview/PT_holiday_hero_image.png * [AdvancedPaste]Add all BitmapDecoder supported image filetypes to ImageToText (microsoft#35600) Adds support to ImageToText for all image filetypes supported by BitmapDecoder. * [AOT]Clean up some AOT build issues in PowerAccent.Core (microsoft#36264) * init * Use AotCompatibility instead * Replace typeof(Lanaguge) with GetValues<Language> * Create new folder to place source generation context file. --------- Co-authored-by: Yu Leng (from Dev Box) <[email protected]> * [WinUI3]Fix Windows 10 title bar borders (microsoft#36429) * Fix borders for windows in the Settings UI * Fix HOSTS window * Fix Advanced Paste * Fix Environment Variables * Fix File Locksmith * Fix Peek, with a caveat * Fix Registry Preview * Remove unused imports * Clean up imports in OobeShellPage * Move OSVersionHelper from Common.UI up into ManagedCommon * [QuickAccent]Fix unstable language loading (microsoft#36721) * [Peek]Bring into foreground if previously minimized (microsoft#36506) Added Activate() to bring Peek.UI window into focus upon Toggle. This allows the UI to be presented even if it was previously minimized. * Update Run docs README (microsoft#36857) * Update Run docs README * Remove System dupe * [Monaco]Make minimap toggleable (microsoft#33742) * [Monaco]Fix Json format preview setting (microsoft#36867) * [KBM]Added option for exact match shortcut (microsoft#36000) * Added option for exact match shortcut * Fix spell-check * [Deps][Security]Update .NET Packages from 9.0.0 to 9.0.1 (microsoft#36879) * [Deps] Update NuGet packages to version 9.0.1 Updated several NuGet packages from version 9.0.0 to 9.0.1, including: - Microsoft.Data.Sqlite - Microsoft.Bcl.AsyncInterfaces - Microsoft.Extensions.DependencyInjection - Microsoft.Extensions.Logging - Microsoft.Extensions.Logging.Abstractions - Microsoft.Extensions.Hosting - Microsoft.Extensions.Hosting.WindowsServices - Microsoft.Win32.SystemEvents - Microsoft.Windows.Compatibility - System.CodeDom - System.ComponentModel.Composition - System.Configuration.ConfigurationManager - System.Data.OleDb - System.Diagnostics.EventLog - System.Diagnostics.PerformanceCounter - System.Drawing.Common - System.Management - System.Runtime.Caching - System.ServiceProcess.ServiceController - System.Text.Encoding.CodePages - System.Text.Json * [Deps] Update NOTICE.md * [Peek]Fix using the correct Monaco assets at runtime (microsoft#36890) * [Workspaces] fixing bug: editor starts outside of visible desktop area (microsoft#36769) * [Workspaces] fixing bug: editor starts outside of visible desktop area * Update src/modules/Workspaces/WorkspacesEditor/MainWindow.xaml.cs Co-authored-by: Seraphima Zykova <[email protected]> --------- Co-authored-by: Seraphima Zykova <[email protected]> * [Workspaces] Saving app properties on launch and recapture (microsoft#36751) * [Workspaces] Implementing set and get GUID to/from HWND to distinguish windows moved by the Workspaces tool * After launch and capture copy the CLI args from the "original" project * Fix getting GUID * spell check * modification to be able to handle different data sizes on different systems * code optimisation * Replacing string parameter by InvokePoint * renaming variable * [AdvancedPaste]Use background thread for interactions between runner and Advanced Paste (microsoft#36858) * [Advanced Paste] Use background thread for runner-Advanced Paste interaction * Fixed typo * [VCM]Deprecate the Video Conference Mute utility (microsoft#36772) * Remove all VideoConferenceMute related code and files * Clean up vcm driver registry keys * Also remove the Webcam report tool * Also clean out video conference on the installer * Fix spellcheck * Remove comment about video conf * Update gpo files revision * Revert removing the VCM policies * Deprecate VCM GPO policy * Change deprecation message to show first supported version * Tweak supported strings in the adml * Goodbye friends, you are forever part of the team (microsoft#36905) * Goodbye friends Forever part of the team 😢 * Update COMMUNITY.md * Fix formatting issues in COMMUNITY.md * [New utility]Sysinternals ZoomIt (microsoft#35880) * ZoomIt initial code dump * Change vcxproj to normalize dependency versions * Fix code quality to build * Add to PowerToys solution * Clean out C-style casts * Fix some more analyzer errors * Constexpr a function * Disable some warnings locally that it seemed better not to touch * Add ZoomIt module interface * Add GPO * Add Settings page with Enable button * Output as PowerToys.ZoomIt.exe * Extract ZoomIt Settings definition to its own header * Make ZoomItModuleInterface build with ZoomItSettings too * WinRT C++ interop for ZoomItSettings * From Registry To PowerToys Json * Properly fix const_cast analyzer error * Initial Settings page loading from registry * Zoom mode settings * Save settings * Add file picker and DemoType file support * Remaining DemoType settings * Have ZoomIt properly reloading Settings and exiting * Remove context menu entries for Options and Exit * ZoomIt simple Break Options * Break advanced options * Simple Record settings * Record Microphone setting * Fix break background file picker title * Font setting * Fix build issues after merge * Add ZoomIt conflict warning to Settings * Exclude Eula from spell checking * Fix spellcheck errors * Fix spell check for accelerated menu items * Remove cursor files from spellcheck. They're binary * Fix forbidden patterns * Fix XAML style * Fix C# analyzers * Fix signing * Also sign module interface dll * Use actual ZoomIt icon * Add OOBE page for ZoomIt * ZoomIt image for Settings * Flyout and Dashboard entries * Fix type speed slider labels * Correctly load default Font * Correctly register shortcuts on ZoomIt startup first run * Fix modifier keys not changing until restart * Show MsgBox on taken shortcut * Start PowerToys Settings * Normalize ZoomIt file properties with rest of PowerToys * Add attribution * Add ZoomIt team to Community.md * More copyright adjustments * Fix spellcheck * Fix MsgBox simultaneous instance to the front * Add mention of capturevideosample code use * Add ZoomIt to process lists * Add telemetry * Add logging * React to gpo * Normalize code to space identation * Fix installer build * Localize percent setting * Fix XAML styling * Update src/settings-ui/Settings.UI/Strings/en-us/Resources.resw Co-authored-by: Stefan Markovic <[email protected]> * Fix spellcheck * One more spellcheck fix * Integrate LiveDraw feature changes from upstream * Fix name reuse in same scope * Fix c-style casts * Also register LIVEDRAW_HOTKEY * Fix newLiveZoomToggleKey * Update LiveZoom description in Settings to take LiveDraw into account * Fix spellcheck * Fix more spellcheck * Fix Sysinternals capitalization * Fix ARM64 Debug build * Support Sysinternals build (microsoft#36873) * Remove unneeded files * Make build compatible with Sysinternals * Separate PowerToys ZoomIt product name (microsoft#36887) * Separate PowerToys ZoomIt product name To help maintain the Sysinternals branding in the standalone version. * Clarify branding-related includes * Remove ZoomIt.sln * Add foxmsft to spell-check names * Add ZoomIt to README * Add ZoomIt to GH templates * Add ZoomIt events to DATA_AND_PRIVACY.md * Remove publish_config.json * Remove publish_config.json from vcxproj too --------- Co-authored-by: Mark Russinovich <[email protected]> Co-authored-by: Alex Mihaiuc <[email protected]> Co-authored-by: John Stephens <[email protected]> Co-authored-by: Stefan Markovic <[email protected]> * [PTRun]Add hotkey to the show telemetry event (microsoft#36869) * [PTRun]Update the code for .NET 9.0.1 - remove workarounds (microsoft#36909) * Revove some unneeded changes after pdating to .net9.1 * [RegistryPreview]Copy context menu, data tooltip, MULTI_SZ fix (microsoft#36631) * add context menus * string resources for contextmenu * fix line break parsing for MULTI_SZ * better presentation of multiline values and value tooltip * cleanup * [MWB] - refactoring "Common" classes - Common.Log.cs, Common.Receiver.cs (microsoft#35726) * [PTRun]Add setting for different trigonometric units in Calculator (microsoft#36717) * Added angle units to PowerToys Run Calculator plugin. * Update Resources.resx * Added GitHub SpellCheck rule for 'gradians'. --------- Co-authored-by: Heiko <[email protected]> * [ci]Remove steps to build abstracted utilities packages (microsoft#36934) * [Settings]Update GPO infobar icon, improve some pages and fix bugs (microsoft#33703) * changes part 1 * fix xaml code * changes part 2 * fix cmdNotFound page * Update PowerOcrPage * More Pages changed * More Pages changed * revert temporary change * fix spelling * add resw comment * add resw comment * Update MouseWihtoutBorderPage.xaml * PowerPreview page * workspaces page * fix awake page gpo handling * NewPlus page * update new+ page! * AdvancedPaste.xaml: Move Info bar. * Update MouseJumpPanel.xaml * Update GeneralPage.xaml * fix position of info bar and some ui quirks * fix xaml style * fix string resources * string changes * prepare megre main * update new+ page * zoomit page * various fixes * [Common]NotificationUtil helper class with FileWatcher (microsoft#36720) * add NotificationUtil helper with file watcher and cache * fix spellcheck * indentation * [PTRun][Docs]Add YubicoOauthOTP to Third-Party plugins (microsoft#36761) * [PTRun]Fixed typo in Value Generator messages (microsoft#36951) * [AOT] Clean up some AOT issues in Advanced Paste module (microsoft#36297) * Clean up the aot build issue. * Merge main and clean up new AOT build issue * Update LogEvent define. * Update src/modules/AdvancedPaste/AdvancedPaste/Helpers/LogEvent.cs Co-authored-by: Jeremy Sinclair <[email protected]> * update typo bug * Remove unused allow list item * Create a new folder to place source generation context * Merge main and rename LogEvent to AIServiceFormatEvent --------- Co-authored-by: Yu Leng (from Dev Box) <[email protected]> Co-authored-by: Jeremy Sinclair <[email protected]> * xaml format * [check-spelling] Update metadata Update for https://github.com/zadjii-msft/PowerToys/actions/runs/12884838755/attempts/1 Accepted in #346 (comment) Signed-off-by: check-spelling-bot <[email protected]> on-behalf-of: @check-spelling <[email protected]> --------- Signed-off-by: Shawn Yuan <[email protected]> Signed-off-by: check-spelling-bot <[email protected]> Co-authored-by: Laszlo Nemeth <[email protected]> Co-authored-by: Seraphima <[email protected]> Co-authored-by: donlaci <[email protected]> Co-authored-by: Ionuț Manța <[email protected]> Co-authored-by: Jaime Bernardo <[email protected]> Co-authored-by: Jeremy Sinclair <[email protected]> Co-authored-by: Ani <[email protected]> Co-authored-by: PesBandi <[email protected]> Co-authored-by: Wenjian Chern <[email protected]> Co-authored-by: Youssef Victor <[email protected]> Co-authored-by: Clint Rutkas <[email protected]> Co-authored-by: Josh Soref <[email protected]> Co-authored-by: leileizhang <[email protected]> Co-authored-by: Den Delimarsky 🔐 <[email protected]> Co-authored-by: Niels Laute <[email protected]> Co-authored-by: Davide Giacometti <[email protected]> Co-authored-by: Heiko <[email protected]> Co-authored-by: Shuai Yuan <[email protected]> Co-authored-by: moooyo <[email protected]> Co-authored-by: Yu Leng (from Dev Box) <[email protected]> Co-authored-by: Jerry Xu <[email protected]> Co-authored-by: Demitrius Nelon <[email protected]> Co-authored-by: Kai Tao <[email protected]> Co-authored-by: Connor Plante <[email protected]> Co-authored-by: Connor Plante <[email protected]> Co-authored-by: Domen Soklič <[email protected]> Co-authored-by: Hao Liu <[email protected]> Co-authored-by: Hao Liu (from Dev Box) <[email protected]> Co-authored-by: immi <[email protected]> Co-authored-by: Asif Islam <[email protected]> Co-authored-by: Kayla Cinnamon <[email protected]> Co-authored-by: Dave Rayment <[email protected]> Co-authored-by: Neil McAlister <[email protected]> Co-authored-by: Mark Russinovich <[email protected]> Co-authored-by: Alex Mihaiuc <[email protected]> Co-authored-by: John Stephens <[email protected]> Co-authored-by: Michael Clayton <[email protected]> Co-authored-by: Nathan Gill <[email protected]> Co-authored-by: Daniel Nilsson <[email protected]> Co-authored-by: Stefan Markovic <[email protected]>
* Add 3 settings for Clint Is your name Clint? Do you like settings? Did you hate that backspace on the main page could dismiss the palette? If you said yes to any of that, you're in luck! This PR is for you! This PR adds three new settings: * `BackspaceGoesBack`: Controls if backspace with an empty search takes you back a level * `SingleClickActivates`: Allows users to toggle between the "single click selects, double activates" vs "single click activates" behavior * `HighlightSearchOnActivate`: When `true` (**default**), this will select the text in the search bar when the window is summoned This drive-by fixes a bug where clicking to select an item stole focus from the search box. closes #306 * spel
Whoops. Activating the app from the taskbar comes in off the UI thread This may have been an additional cause of #327
Bits of status messages that were omitted from #281. This lets extensions hide messages (and exposes the helper in the helper lib). It also adds support for displaying progress as a progress bar underneath the text of the status message. I'll need An Adult to help with the XAML, to re-template the InfoBar to allow a progress wheel in the icon instead, but for now? good enough. I'm doing this to unblock the next PR, which should add some rudimentary winget support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.