-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hosts] Converting manual release-check-list tests to UI-Test Automation and Adding more UI-Test-cases #37657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR migrates manual tests for the Hosts File Editor module to UI-test automation and adds extra UI-test cases to cover various user interactions and error conditions. Key changes include:
- Adding and updating UI-test cases in Hosts.UITests (e.g., Warning dialog, Empty view, and Validation for multiple hosts).
- Creating a migration progress tracking markdown file.
- Enhancing UITestAutomation components with updated element classes and improved find methods.
Reviewed Changes
File | Description |
---|---|
src/common/UITestAutomation/SessionHelper.cs | Updated session initialization and cleanup logic for UI tests. |
src/modules/Hosts/Hosts.UITests/Release-Test-Checklist-Migration-Progress.md | Added a migration tracking document for UI-tests conversion. |
src/modules/Hosts/Hosts.UITests/HostsSettingTests.cs | Introduced tests for warning dialog behavior and window state after user actions. |
src/common/UITestAutomation/Element/* and Session.cs | General updates and improvements to UI element wrappers and element lookup functions. |
src/modules/Hosts/Hosts.UITests/HostModuleTests.cs | Added new tests covering empty view, adding entries, and host-validation scenarios. |
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This pull request converts manual release check-list tests for the Hosts File Editor module into automated UI tests and adds additional UI test cases. It also includes updates in the UI test automation framework to support consistent element lookup and interaction.
- Added UI tests in HostsSettingTests.cs and HostModuleTests.cs for various Hosts File Editor scenarios.
- Introduced a migration progress tracking markdown file for the manual-to-automation conversion.
- Updated common UI test automation elements (e.g., NavigationViewItem, Button, TextBox, Window) and session management.
Reviewed Changes
File | Description |
---|---|
src/common/UITestAutomation/SessionHelper.cs | New session helper for UI tests initialization and cleanup |
src/modules/Hosts/Hosts.UITests/HostsSettingTests.cs | Added tests for warning dialogs and window state validations |
src/modules/Hosts/Hosts.UITests/Release-Test-Checklist-Migration-Progress.md | Migration progress tracking for manual-to-automation conversion |
src/common/UITestAutomation/Element/*.cs | New and revised UI element implementations for consistent control type matching |
src/modules/Hosts/Hosts.UITests/HostModuleTests.cs | Added tests for empty view, adding entries, and multiple-host validation |
src/common/UITestAutomation/Session.cs, Element.cs, FindHelper.cs, UITestBase.cs | Refactors and improvements to support updated element lookup and actions |
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/modules/Hosts/Hosts.UITests/HostsSettingTests.cs:82
- The assertion message contradicts the test scenario. Since the check verifies that the Hosts File Editor is not closed, the error message should be updated to "Hosts File Editor should NOT be closed".
Assert.IsFalse(this.IsHostsFileEditorClosed(), "Hosts File Editor should be closed");
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…icrosoft/powertoys into dev/nxu/AddHostSaveErrorUITest
This comment has been minimized.
This comment has been minimized.
…icrosoft/powertoys into dev/nxu/AddHostSaveErrorUITest
…icrosoft/powertoys into dev/nxu/AddHostSaveErrorUITest
…icrosoft/powertoys into dev/nxu/AddHostSaveErrorUITest
…icrosoft/powertoys into dev/nxu/AddHostSaveErrorUITest
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Converted manual validation-cases
UI-Tests:
Validation Steps Performed
All UI-Test cases passed