Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RegistryPreview] Extended preview for value data #37689

Open
wants to merge 77 commits into
base: main
Choose a base branch
from

Conversation

htcfreek
Copy link
Collaborator

@htcfreek htcfreek commented Feb 28, 2025

Summary of the Pull Request

Add a button to the data grid that shows a windows for complex value preview.

Screenshots

Button
image

Context menu (Usefull on long data, if button is scrolled out of view.)
image

Preview: REG_SZ
image

Preview: REG_MULTI_SZ
image

Preview: REG_EXPAND_SZ
image

Preview: REG_DWORD and REG_QWORD
image

Preview: REG_BINARY
image
image

PR Checklist

Detailed Description of the Pull Request / Additional comments

Additionally this PR updates the context menu for values.

Validation Steps Performed

Tested code with a local build.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@htcfreek htcfreek changed the title 🚧 [RegistryPreview] Enhanced preview windows for value data [RegistryPreview] Enhanced preview windows for value data Mar 1, 2025
@htcfreek htcfreek self-assigned this Mar 1, 2025
@htcfreek htcfreek marked this pull request as ready for review March 1, 2025 15:27
@htcfreek htcfreek added the Needs-Review This Pull Request awaits the review of a maintainer. label Mar 1, 2025
@htcfreek htcfreek requested a review from niels9001 March 1, 2025 15:28
@htcfreek htcfreek changed the title [RegistryPreview] Enhanced preview windows for value data [RegistryPreview] Enhanced preview for value data Mar 1, 2025
@htcfreek htcfreek marked this pull request as draft March 1, 2025 18:40
@htcfreek

This comment has been minimized.

@htcfreek htcfreek requested a review from a team as a code owner March 19, 2025 17:56
@htcfreek
Copy link
Collaborator Author

@jaimecbernardo, @crutkas
All bugs are fixed and the control is implemented including customized context menu, translation and theme support.
Can you please trigger a pipeline build that we can see if the pipeline succeeds. That would be amazing.

Screenshot:
image
High Contrast theme "Dusk".

@jaimecbernardo
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This comment has been minimized.

This comment has been minimized.

@htcfreek
Copy link
Collaborator Author

htcfreek commented Mar 20, 2025

Small update: With the changes from today the "HexBox" control used for the Reg_Binary looks and behaves in all themes like a native WinUI3 control.

image

@htcfreek

This comment has been minimized.

@htcfreek htcfreek changed the title [RegistryPreview] Enhanced preview for value data [RegistryPreview] Extended preview for value data Mar 22, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@zhaopy536 zhaopy536 self-requested a review March 24, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Idea-Enhancement New feature or request on an existing product Needs-Review This Pull Request awaits the review of a maintainer. Product-Registry Preview Refers to the Registry Preview PowerToy
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants