Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmdpal] UX tweaks #38087

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[cmdpal] UX tweaks #38087

wants to merge 5 commits into from

Conversation

niels9001
Copy link
Contributor

@niels9001 niels9001 commented Mar 21, 2025

  • Removing the redundant icon + text in the bottom left corner
  • Minor styling tweaks
  • Adding subtle show/hide animations
  • Improved narrator support for Settings button
  • Minor design tweaks to the tags for better visibility (still needs more work in the future)

SubtleAnimations

@crutkas crutkas added in for .90 Product-Command Palette Refers to the Command Palette utility labels Mar 21, 2025
@zadjii
Copy link
Contributor

zadjii commented Mar 22, 2025

quick notes:

  • the tags, me gusta those. Especially on top-level items, they feel real better
  • the page title text on the bottom right actually isn't redundant - pages can set that too:
    image
  • should the details slide in, rather than pop in?
  • Do the narrator strings need to be set with x:Uid, so they can be localized?

@niels9001
Copy link
Contributor Author

quick notes:

  • the tags, me gusta those. Especially on top-level items, they feel real better
  • the page title text on the bottom right actually isn't redundant - pages can set that too:
    image
  • should the details slide in, rather than pop in?
  • Do the narrator strings need to be set with x:Uid, so they can be localized?

Great points.. See latest commits for addressing your feedback.

@zadjii-msft
Copy link
Member

See latest commits for addressing your feedback

omg its so hot

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (5)
  • src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/CommandBar.xaml: Language not supported
  • src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/Tag.xaml: Language not supported
  • src/modules/cmdpal/Microsoft.CmdPal.UI/ExtViews/ListPage.xaml: Language not supported
  • src/modules/cmdpal/Microsoft.CmdPal.UI/Pages/ShellPage.xaml: Language not supported
  • src/modules/cmdpal/Microsoft.CmdPal.UI/Strings/en-us/Resources.resw: Language not supported
@yeelam-gordon
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in for .90 Product-Command Palette Refers to the Command Palette utility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants