Fix install location missing in uninstall registry entry#41639
Closed
Copilot wants to merge 1 commit into
Closed
Conversation
Copilot
AI
changed the title
[WIP] Install location missing in Uninstall registry entry
Fix install location missing in uninstall registry entry
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PowerToys installer was not setting the
InstallLocationvalue in the Windows uninstall registry entry, preventing Windows Add/Remove Programs and other system tools from properly locating the PowerToys installation directory.Root Cause
While the installer was setting the
ARPINSTALLLOCATIONMSI property, this WiX approach doesn't always reliably write theInstallLocationregistry value in all scenarios. The verification script even treated missingInstallLocationas "normal behavior," but this prevented proper integration with Windows system tools.Solution
Added an explicit registry component (
UninstallRegistryComponent) to both WiX 3 and WiX 5 installers that directly writes theInstallLocationvalue to the uninstall registry key:This ensures the
InstallLocationvalue is always written to the correct registry hive (HKLM for per-machine installations, HKCU for per-user installations) regardless ofARPINSTALLLOCATIONbehavior.Changes Made
UninstallRegistryComponentand referenced it inCoreFeatureUninstallRegistryComponentand referenced it inCoreFeatureInstallLocationand report missing values as failuresBenefits
InstallLocationis now reliably set for both per-machine and per-user installationsFixes #41638.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.