feat(peek): support File Explorer Home page items#45394
Open
yeelam-gordon wants to merge 1 commit intomainfrom
Open
feat(peek): support File Explorer Home page items#45394yeelam-gordon wants to merge 1 commit intomainfrom
yeelam-gordon wants to merge 1 commit intomainfrom
Conversation
Fixes #42414 Adds path resolution for items selected from the File Explorer Home page. The Home page displays recent files and pinned items as shell references, which need to be resolved to their actual file paths for Peek to preview. Changes: - Added HomePagePathResolver helper class - Detects Home page shell locations - Resolves shell item references to file paths
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix issue #42414 where Peek doesn't work on the File Explorer Home page. The change adds a new HomePagePathResolver helper class to resolve special File Explorer locations to their actual file paths.
Changes:
- Adds HomePagePathResolver.cs with methods to detect Home page locations and resolve shell paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Enables Peek to preview files selected from File Explorer's Home page (Quick Access, Recent files, Pinned items). Previously, these items couldn't be previewed because their shell paths weren't resolved to actual file system paths.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Problem
Files shown on File Explorer's Home page (Recent, Quick Access, Pinned) use shell namespace paths that Peek couldn't resolve. Users couldn't preview these files without first navigating to their actual location.
Solution
Added
HomePagePathResolver.csinsrc/modules/peek/Peek.Common/Helpers/that:Validation Steps Performed