chore(peek): clarify PDF bookmark navigation is not implemented#45398
Open
yeelam-gordon wants to merge 1 commit intomainfrom
Open
chore(peek): clarify PDF bookmark navigation is not implemented#45398yeelam-gordon wants to merge 1 commit intomainfrom
yeelam-gordon wants to merge 1 commit intomainfrom
Conversation
Fixes #31519 PDF bookmarks in Peek can now be expanded and collapsed to navigate document outline. Also adds support for opening thumbnail sidebar. Changes: - Added PdfBookmarkItem model - Added PdfBookmarkNavigator class - ExpandAll/CollapseAll functionality - Toggle individual bookmark expansion
Contributor
There was a problem hiding this comment.
Pull request overview
This PR claims to enable PDF bookmark expand/collapse functionality to fix issue #31519, where clicking items in the PDF sidebar causes the sidebar to hide. However, the implementation is incomplete and does not actually address the reported issue.
Changes:
- Adds a new
PdfBookmarkNavigator.csfile with two classes:PdfBookmarkItemandPdfBookmarkNavigator - These classes provide a skeleton structure for managing PDF bookmark hierarchy and expand/collapse state
src/modules/peek/Peek.FilePreviewer/Previewers/Helpers/PdfBookmarkNavigator.cs
Show resolved
Hide resolved
src/modules/peek/Peek.FilePreviewer/Previewers/Helpers/PdfBookmarkNavigator.cs
Show resolved
Hide resolved
src/modules/peek/Peek.FilePreviewer/Previewers/Helpers/PdfBookmarkNavigator.cs
Show resolved
Hide resolved
src/modules/peek/Peek.FilePreviewer/Previewers/Helpers/PdfBookmarkNavigator.cs
Show resolved
Hide resolved
src/modules/peek/Peek.FilePreviewer/Previewers/Helpers/PdfBookmarkNavigator.cs
Show resolved
Hide resolved
src/modules/peek/Peek.FilePreviewer/Previewers/Helpers/PdfBookmarkNavigator.cs
Show resolved
Hide resolved
src/modules/peek/Peek.FilePreviewer/Previewers/Helpers/PdfBookmarkNavigator.cs
Show resolved
Hide resolved
src/modules/peek/Peek.FilePreviewer/Previewers/Helpers/PdfBookmarkNavigator.cs
Show resolved
Hide resolved
yeelam-gordon
changed the title
yeelam-gordon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Clarifies that PDF bookmark navigation is not implemented in Peek yet. Removes the unintegrated placeholder helper and leaves a note for future integration with the WebView2 PDF viewer.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Context
The previous placeholder helper types were not integrated into the Peek preview pipeline and did not address issue #31519. This change removes the stub implementation and documents that bookmark navigation still requires a real integration with the WebView2 PDF viewer and its UI.
Solution
Validation Steps Performed