Skip to content

[File Locksmith] Fix IPC text-mode file I/O corrupting Unicode paths #47361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MuyuanMS merged 4 commits into from
May 25, 2026
+8 −3
Merged

[File Locksmith] Fix IPC text-mode file I/O corrupting Unicode paths #47361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
024dd14
Initial plan
Copilot Apr 29, 2026
2e43ce4
Fix IPC Writer opening in text mode, corrupting Unicode paths
Copilot Apr 29, 2026
27d771b
Address review: check stream open status and fix other write path
MuyuanMS May 14, 2026
511e610
Fix ReadPathsFromFile ifstream also opening in text mode
Copilot May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/modules/FileLocksmith/FileLocksmithLib/IPC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@ namespace ipc

try
{
m_stream = std::ofstream(path);
m_stream = std::ofstream(path, std::ios::binary);
Copy link
Copy Markdown
Contributor

@MuyuanMS MuyuanMS May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an explicit is_open() check in ipc::Writer::start() after opening the stream in binary mode, so open failures now return E_FAIL instead of incorrectly returning S_OK.

Copy link
Copy Markdown
Contributor

@MuyuanMS MuyuanMS May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found the other last-run.log write path in src/modules/FileLocksmith/FileLocksmithLibInterop/NativeMethods.cpp (NativeMethods::StartAsElevated) and switched that std::ofstream open to std::ios::binary as well.

if (!m_stream.is_open())
{
return E_FAIL;
}

return S_OK;
}
catch (...)
Expand Down
4 changes: 2 additions & 2 deletions src/modules/FileLocksmith/FileLocksmithLibInterop/NativeMethods.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ namespace winrt::PowerToys::FileLocksmithLib::Interop::implementation

com_array<hstring> NativeMethods::ReadPathsFromFile()
{
std::ifstream stream(paths_file());
std::ifstream stream(paths_file(), std::ios::binary);

std::vector<std::wstring> result_cpp;
std::wstring line;
Expand Down Expand Up @@ -98,7 +98,7 @@ namespace winrt::PowerToys::FileLocksmithLib::Interop::implementation

bool NativeMethods::StartAsElevated(array_view<hstring const> paths)
{
std::ofstream stream(paths_file());
std::ofstream stream(paths_file(), std::ios::binary);
const WCHAR newline = L'\n';

for (uint32_t i = 0; i < paths.size(); i++)
Expand Down
Loading