Skip to content

CmdPal: Fix image overflow in Details panel #47385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −7
Draft

CmdPal: Fix image overflow in Details panel #47385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7af7e06
Initial plan
Copilot Apr 29, 2026
a6f3136
CmdPal: Fix image overflow in Details panel by defaulting FitColumnWi…
Copilot Apr 29, 2026
64bc977
Address review: case-insensitive FitMode comparison and DPI note
MuyuanMS May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/modules/cmdpal/Microsoft.CmdPal.UI/Helpers/MarkdownImageProviders/ImageProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public async Task<Image> GetImage(string url)
return RtbInlineImageFactory.Create(imageSource.ImageSource, new RtbInlineImageFactory.InlineImageOptions
{
DownscaleOnly = imageSource.Hints.DownscaleOnly ?? true,
FitColumnWidth = imageSource.Hints.FitMode == "fit",
FitColumnWidth = imageSource.Hints.FitMode is null || imageSource.Hints.FitMode.Equals("fit", StringComparison.OrdinalIgnoreCase),
MaxWidthDip = imageSource.Hints.MaxPixelWidth,
MaxHeightDip = imageSource.Hints.MaxPixelHeight,
Comment on lines 23 to 27
Copy link
Copy Markdown
Contributor

@MuyuanMS MuyuanMS May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed — the FitMode check in ImageProvider now uses StringComparison.OrdinalIgnoreCase, so mixed-case query values still take the fit path.

WidthDip = imageSource.Hints.DesiredPixelWidth,
Expand Down
13 changes: 7 additions & 6 deletions src/modules/cmdpal/ext/SamplePagesExtension/Pages/SampleMarkdownImagesPage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@ static string GetContentMarkup(Uri path1, Uri path2)
For URIs that support query parameters (file, http, ms-appx, ms-appdata), you can provide hints to control scaling

- `--x-cmdpal-fit`
- `none`: no automatic scaling, provides image as is (default)
- `fit`: scale to fit the available space
- `fit`: scale to fit the available space (default)
- `none`: no automatic scaling, provides image as is
- `--x-cmdpal-upscale`
- `true`: allow upscaling
- `false`: downscale only (default)
Comment on lines +158 to 161
Copy link
Copy Markdown
Contributor

@MuyuanMS MuyuanMS May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note to the sample Markdown images page calling out that the no-fit sample uses source pixel size, so it can differ from the natural visual size under non-100% DPI scaling.

Expand All @@ -169,18 +169,19 @@ For URIs that support query parameters (file, http, ms-appx, ms-appdata), you ca
## Examples

### No scaling
ℹ️ This sample uses the source pixel size, so under non-100% DPI scaling the rendered size can differ from the image's natural visual size.
```xml
![green rectangle]({{path1}})
![green rectangle]({{path1}}?--x-cmdpal-fit=none)
```

![green rectangle]({{path1}})
![green rectangle]({{path1}}?--x-cmdpal-fit=none)

### Scale to fit (scaling down only by default)
```xml
![green rectangle]({{path1}}?--x-cmdpal-fit=fit)
![green rectangle]({{path1}})
```

![green rectangle]({{path1}}?--x-cmdpal-fit=fit)
![green rectangle]({{path1}})

### Scale to fit (in both direction)
```xml
Expand Down
Loading