build(common): align C++ standard and spdlog include settings#48021
Draft
flcdrg wants to merge 1 commit into
Draft
build(common): align C++ standard and spdlog include settings#48021flcdrg wants to merge 1 commit into
flcdrg wants to merge 1 commit into
Conversation
… tests Two independent compile failures in msbuild.binlog were caused by toolset compatibility issues introduced by newer MSVC versions. 1) CalculatorEngineCommon (Debug|x64): switch LanguageStandard from stdcpp17 to stdcpp20. - C++/WinRT generated headers may fall back to <experimental/coroutine> under C++17. - With MSVC 14.51 this path now trips STL1011/C2338 deprecation enforcement. - Moving to C++20 ensures standard coroutine support and avoids the deprecated fallback. 2) UnitTests-CommonUtils: force-include deps/spdlog-msvc-fix/include/spdlog-msvc-fix.h. - This test project consumed bundled spdlog/fmt headers but did not apply the repo's MSVC compatibility shim. - On MSVC 14.51+, missing stdext::checked_array_iterator causes C2653/C2061/C7568 cascades. - Adding ForcedIncludeFiles aligns behavior with other spdlog consumers in the repo. No functional behavior changes are intended; this is a build/toolchain compatibility fix. Expected result: eliminate the coroutine deprecation failure and the spdlog stdext compile cascade observed in msbuild.binlog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR updates common project build settings to improve reliability and compatibility.
Impacted paths:
PR Checklist
N/A:
Detailed Description of the Pull Request / Additional comments
The change set focuses on build/toolchain configuration only:
Risk is low and scoped to build configuration, but downstream effects may include stricter compiler behavior in Debug x64 for CalculatorEngineCommon.
Validation Steps Performed
Automated tests run:
Build/test status:
Reason: