CmdPal: Fix bookmark launch fallback handling#48712
Draft
michaeljolley wants to merge 4 commits into
Draft
Conversation
added 3 commits
June 17, 2026 23:34
… spaces, percent-encoding; add TestLaunchOverride hook and launcher fallback for tests (#48672)
michaeljolley
added
the
Product-Command Palette
…ly tests (#48672) - Extract NormalizePathForWindows from BookmarkResolver into a dedicated internal helper class (Services/PathNormalization.cs). - Add safe trailing-whitespace trimming (incl. NBSP) so trailing copy/paste artifacts don't defeat File.Exists probes; trailing dots are deliberately preserved to avoid lossy transformations. - BookmarkResolver delegates through a thin private wrapper so existing call sites and behavior are unchanged. - Add PathNormalizationTests covering NFC, non-ASCII preservation, trailing-whitespace handling, and Windows-only long-path / NT-object prefix stripping. Windows-only assertions use Assert.Inconclusive on non-Windows agents so CI on Linux/macOS skips them cleanly.
michaeljolley
changed the title
michaeljolley
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BookmarkResolverpath probing/classification heuristics for bookmark strings with spaces, punctuation, and non-ASCII characters%xxsequences are present)NormalizePathForWindows(NFC normalization + safe long-path prefix stripping) before probe/classification useDirectory/ExplorerOpenFixes #48672