wait_stats_capture_mode query store option #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzsquared
requested review from
zijchen,
chlafreniere and
llali
as code owners
There was a problem hiding this comment.
Copilot reviewed 4 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (7)
- SqlScriptDom/Parser/TSql/Ast.xml: Language not supported
- SqlScriptDom/Parser/TSql/TSql140.g: Language not supported
- SqlScriptDom/Parser/TSql/TSql150.g: Language not supported
- SqlScriptDom/Parser/TSql/TSql160.g: Language not supported
- SqlScriptDom/Parser/TSql/TSql170.g: Language not supported
- Test/SqlDom/Baselines140/AlterDatabaseOptionsTests140.sql: Language not supported
- Test/SqlDom/TestScripts/AlterDatabaseOptionsTests140.sql: Language not supported
llali
approved these changes
Jan 17, 2025
| @@ -1263,7 +1264,7 @@ internal static class CodeGenerationSupporter | |||
| internal const string Russian = "RUSSIAN"; | |||
| internal const string Romanian = "ROMANIAN"; | |||
| internal const string Brazilian = "BRAZILIAN"; | |||
| internal const string NorwegianBokmal = "NORWEGIAN (BOKM�L)"; | |||
| internal const string NorwegianBokmal = "NORWEGIAN (BOKM�L)"; | |||
There was a problem hiding this comment.
nope, investigating the git setting that caused this
There was a problem hiding this comment.
file encoding was utf8, which is sensitive to messing up the combined bytes of some characters. the most definitive fix was to convert the file to utf8 bom file encoding, which is used by a number of other c# files in the project already
zijchen
approved these changes
Jan 17, 2025
llali
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applies to 140+ and Azure SQL DB
https://learn.microsoft.com/en-us/sql/t-sql/statements/alter-database-transact-sql-set-options?view=sql-server-ver16#wait_stats_capture_mode--on--off-
fixes #100