Skip to content

feat: giving the gift of vision to OpenAIChatCompletions #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sss04
Copy link
Contributor

@sss04 sss04 commented Mar 19, 2025

Related Issues/PRs

#xxx

Adding image support to OpenAIChatCompletion

Briefly describe the changes included in this Pull Request.

How is this patch tested?

Added just one image test for now - I will add more, especially checking base64 encodings and null values, soon!

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

@sss04 sss04 requested a review from mhamilton723 as a code owner March 19, 2025 15:28
@sss04
Copy link
Contributor Author

sss04 commented Mar 19, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 4.87805% with 39 lines in your changes missing coverage. Please review.

Project coverage is 83.17%. Comparing base (b2f4080) to head (4993895).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ure/synapse/ml/services/openai/OpenAISchemas.scala 8.69% 21 Missing ⚠️
...apse/ml/services/openai/OpenAIChatCompletion.scala 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2356      +/-   ##
==========================================
- Coverage   83.67%   83.17%   -0.51%     
==========================================
  Files         331      331              
  Lines       17177    17211      +34     
  Branches     1526     1529       +3     
==========================================
- Hits        14373    14315      -58     
- Misses       2804     2896      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +111 to +114
"content" -> JsString("")

case (Some(_), Some(_)) =>
"content" -> JsString("")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is actually an error we should yell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants