-
Notifications
You must be signed in to change notification settings - Fork 854
chore: Remove OpenAICompletion #2447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: Remove OpenAICompletion #2447
Conversation
|
Hey @ranadeepsingh 👋! We use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
To test your commit locally, please follow our guild on building from source. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated OpenAICompletion class and all associated code, as the OpenAI Completions API ended support in July 2023 and is no longer supported by current models.
- Removed the
OpenAICompletionclass and its test suite - Removed the
HasPromptInputstrait which was only used byOpenAICompletion - Simplified
OpenAIPromptby removing legacy model handling and streamlining service configuration
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/OpenAICompletion.scala |
Complete removal of the deprecated OpenAICompletion class |
cognitive/src/test/scala/com/microsoft/azure/synapse/ml/services/openai/OpenAICompletionSuite.scala |
Removal of test suite for OpenAICompletion |
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/OpenAI.scala |
Removed HasPromptInputs trait that was only used by OpenAICompletion |
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/OpenAIPrompt.scala |
Removed legacy model detection, simplified service configuration to only handle chat-based services, removed unused import, and updated parameter documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2447 +/- ##
==========================================
+ Coverage 84.35% 84.43% +0.07%
==========================================
Files 335 334 -1
Lines 17729 17695 -34
Branches 1621 1618 -3
==========================================
- Hits 14955 14940 -15
+ Misses 2774 2755 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think we should sunset this (i.e. not spend time keeping it up to date with new features) but not remove it until openai stops serving the endpoint. Thoughts? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…completions rebase with main branch
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Related Issues/PRs
#xxx
What changes are proposed in this pull request?
None of the latest models support the OpenAI Completions API which ended support on July 2023.
Removing all use of OpenAICompletions
How is this patch tested?
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?
website/docs/documentationfolder.Make sure you choose the correct class
estimators/transformersand namespace.DocTablepoints to correct API link.yarn run startto make sure the website renders correctly.<!--pytest-codeblocks:cont-->before each python code blocks to enable auto-tests for python samples.WebsiteSamplesTestsjob pass in the pipeline.