-
Notifications
You must be signed in to change notification settings - Fork 854
fix: Fix geospatial test error caused by invalid auth #2450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/azp run |
|
Hey @BrendanWalsh 👋! We use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
To test your commit locally, please follow our guild on building from source. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2450 +/- ##
==========================================
- Coverage 84.38% 84.36% -0.03%
==========================================
Files 335 335
Lines 17690 17711 +21
Branches 1619 1610 -9
==========================================
+ Hits 14928 14941 +13
- Misses 2762 2770 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes authentication errors in Azure Maps asynchronous polling operations by ensuring that subscription-key and api-version query parameters are properly propagated from the initial request to subsequent polling requests.
Key Changes:
- Overrides
extractHeaderValuesForPollingto extract authentication parameters from query strings instead of HTTP headers - Modifies
queryForResultto append extracted parameters to polling URLs - Updates
handlingFuncto pass extracted parameters through the polling flow
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...tive/src/main/scala/com/microsoft/azure/synapse/ml/services/geospatial/AzureMapsTraits.scala
Outdated
Show resolved
Hide resolved
...tive/src/main/scala/com/microsoft/azure/synapse/ml/services/geospatial/AzureMapsTraits.scala
Outdated
Show resolved
Hide resolved
...tive/src/main/scala/com/microsoft/azure/synapse/ml/services/geospatial/AzureMapsTraits.scala
Outdated
Show resolved
Hide resolved
…es/geospatial/AzureMapsTraits.scala Co-authored-by: Copilot <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…toring TestableMapsAsyncReply
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* fix: Fix geospatial test error caused by invalid auth * Update cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/geospatial/AzureMapsTraits.scala Co-authored-by: Copilot <[email protected]> * fix: Use getRawQuery to prevent double-decoding of Azure Maps auth params * fix: Resolve scalastyle violations in AzureMapsTraitsSuite * fix jarloadingutils for inner classes * fix: Resolve FuzzingTest failures by fixing JarLoadingUtils and refactoring TestableMapsAsyncReply * Add fuzzing exemptions for private api --------- Co-authored-by: Copilot <[email protected]>
Related Issues/PRs
Fixes failing Azure Maps tests due to authentication errors during async polling.
What changes are proposed in this pull request?
This PR fixes an issue where the
subscription-keyandapi-versionwere not being correctly passed during the polling phase of asynchronous Azure Maps operations (e.g., batch geocoding).Changes:
MapsAsyncReplyin AzureMapsTraits.scala.extractHeaderValuesForPollingto extract authentication parameters (subscription-key,api-version) from the original request's query string.queryForResultto append these parameters to the polling URL, ensuring the polling requests are properly authenticated.How is this patch tested?
Verified by running the following test suites locally:
com.microsoft.azure.synapse.ml.services.geospatial.AzMapsSearchAddressSuitecom.microsoft.azure.synapse.ml.services.geospatial.AzMapsSearchReverseAddressSuitecom.microsoft.azure.synapse.ml.services.geospatial.AzMapsPointInPolygonSuiteAll tests passed successfully.
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?