-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Node 18 & gatsby 5 #2717
Conversation
OK, that's building fine locally now |
( this PR is worth some attention ) |
Hoping we can make some progress on this; there seem to be a bunch of unrelated content changes. Do you want me to push to this branch to get it de-conflicted? Is there any other work left to be done here? |
It's been a while, but I think most of those changes are either running bootstrap or updating libs to versions which support node 18 - sure give it a shot, I think it was done |
Well, I tried to update this PR... it passes locally but fails in CI. |
Figured it out, The "fix" is to commit the file. If we ever modify it, it'll be modified on disk and should be committed anyway. gitignored but required generated files are such a pain 🙁 I also modified CI to make it complain, replacing #2901 with the same simple diff we do in TS's CI (and I do in my own repos for generated code). |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-glacier-09aa73710-2717.centralus.azurestaticapps.net |
eyyy, nice one |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-glacier-09aa73710-2717.centralus.azurestaticapps.net |
Needs a 2nd pass because it looks like the build command has issues which the local dev server does not, but this updates everything!