Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node 18 & gatsby 5 #2717

Merged
merged 21 commits into from
Apr 24, 2024
Merged

Update to Node 18 & gatsby 5 #2717

merged 21 commits into from
Apr 24, 2024

Conversation

orta
Copy link
Contributor

@orta orta commented Feb 18, 2023

Needs a 2nd pass because it looks like the build command has issues which the local dev server does not, but this updates everything!

image

@orta orta marked this pull request as draft February 18, 2023 19:32
@orta orta marked this pull request as ready for review February 19, 2023 06:59
@orta
Copy link
Contributor Author

orta commented Feb 19, 2023

OK, that's building fine locally now

@orta
Copy link
Contributor Author

orta commented Feb 27, 2023

( this PR is worth some attention )

@jakebailey
Copy link
Member

Hoping we can make some progress on this; there seem to be a bunch of unrelated content changes. Do you want me to push to this branch to get it de-conflicted? Is there any other work left to be done here?

@orta
Copy link
Contributor Author

orta commented Jul 25, 2023

It's been a while, but I think most of those changes are either running bootstrap or updating libs to versions which support node 18 - sure give it a shot, I think it was done

@jakebailey jakebailey added the deploy-preview Enables automatic deployments to preview environments on a PR label Apr 12, 2024
@jakebailey
Copy link
Member

Well, I tried to update this PR... it passes locally but fails in CI.

@jakebailey
Copy link
Member

Figured it out, gatsby-plugin-typegen doesn't generate code when CI=true: https://github.com/cometkim/gatsby-plugin-typegen/blob/b452c4274e35d3e0eebcad930696eb7131d8be8b/plugin/src/utils.ts#L14

The "fix" is to commit the file. If we ever modify it, it'll be modified on disk and should be committed anyway. gitignored but required generated files are such a pain 🙁

I also modified CI to make it complain, replacing #2901 with the same simple diff we do in TS's CI (and I do in my own repos for generated code).

@jakebailey jakebailey added deploy-preview Enables automatic deployments to preview environments on a PR and removed deploy-preview Enables automatic deployments to preview environments on a PR labels Apr 15, 2024
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-glacier-09aa73710-2717.centralus.azurestaticapps.net

@orta
Copy link
Contributor Author

orta commented Apr 16, 2024

eyyy, nice one

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-glacier-09aa73710-2717.centralus.azurestaticapps.net

@jakebailey jakebailey merged commit 44833d7 into microsoft:v2 Apr 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-preview Enables automatic deployments to preview environments on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants