Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ATA: Call delegate.errorMessage upon Errors #3311

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from
Open

ATA: Call delegate.errorMessage upon Errors #3311

wants to merge 2 commits into from

Conversation

seanoch
Copy link

@seanoch seanoch commented Jan 26, 2025 •
edited
Loading

This PR adds calls to the user's delegate.errorMessage()
The API exists but it currently does nothing

@seanoch seanoch force-pushed the ata-call-error-callback branch from 81e896b to 4df5197 Compare January 26, 2025 15:11
@seanoch seanoch force-pushed the ata-call-error-callback branch from 0e03216 to fb127ce Compare January 26, 2025 21:24
@seanoch
Copy link
Author

seanoch commented Jan 28, 2025

@jakebailey Changed to patch, let me know if any additional change is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanoch @jakebailey