Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make links in code blocks inherit syntax highlighter colors #3337

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

mkantor
Copy link
Contributor

@mkantor mkantor commented Feb 22, 2025

See #3335 (comment) and preceding discussion.

Comment on lines +141 to +144
pre code a {
// Don't interfere with syntax highlighting in code blocks
color: inherit;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if there's a better place/way to make this exception. I couldn't tell if there were any particular SASS conventions I should be following.

@mkantor
Copy link
Contributor Author

mkantor commented Feb 22, 2025

With this change links in code are effectively invisible other than a cursor change. They weren't especially noticeable before (despite looking at the docs many times over the years I'd never noticed these links), so this isn't exactly a regression, but I'll happily make further style changes1 if desired.

Footnotes

  1. My first thought is a :hover effect (like adding an underline). That only helps after the link has been pointed at, but makes it more apparent that they're clickable.

@jakebailey jakebailey added the deploy-preview Enables automatic deployments to preview environments on a PR label Feb 22, 2025
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-plant-05c166c10-3337.centralus.5.azurestaticapps.net

@orta
Copy link
Contributor

orta commented Feb 24, 2025

They are supposed to give a hover of the description, but it looks like that isn't happening - its probably not worth blocking the PR but I'll see if I get some time next week to bring that back up to working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-preview Enables automatic deployments to preview environments on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants