Fix incorrect --detach description in container run help text#40149
Open
benhillis wants to merge 1 commit intomicrosoft:feature/wsl-for-appsfrom
Open
Fix incorrect --detach description in container run help text#40149benhillis wants to merge 1 commit intomicrosoft:feature/wsl-for-appsfrom
benhillis wants to merge 1 commit intomicrosoft:feature/wsl-for-appsfrom
Conversation
The help text for 'wslc container run' incorrectly stated that containers start in the background by default and --detach runs in the foreground. The actual behavior (confirmed by ContainerService.cpp) is the opposite: containers start attached (foreground) by default, and --detach runs them in the background. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The help text for
wslc container runincorrectly stated that containers start in the background by default and--detachruns in the foreground. The actual behavior (confirmed byContainerService.cppline 299:WI_SetFlagIf(startFlags, WSLCContainerStartFlagsAttach, !runOptions.Detach)) is the opposite: containers start attached (foreground) by default, and--detachruns them in the background.This fix updates the en-US locale string. Other locales will pick up the correction through the standard localization pipeline.
Before: Runs a container. By default, the container is started in the background; use --detach to run in the foreground.
After: Runs a container. By default, the container is started in the foreground; use --detach to run in the background.